Repository navigation
ci: report a green CI check on PRs that change no code - #5184
Conversation
The main ruleset requires the CI check, but a PR outside CI's path filter never started the workflow, so the check waited forever. CI now starts on every pull request. When the PR changes none of the paths that used to trigger it, a first step marks the run skipped and every later step is bypassed, so the required check passes in seconds. Pushes keep their path filter. Shipped fast, no review.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Why
main's ruleset requires theCIcheck. After #5183 dropped agent files from CI's path filter, an agent-only PR such as #5182 never started the workflow, soCIsat at "Expected — Waiting for status to be reported". Docs-only andapps/www-only PRs already had the same problem.What changed
ci.ymlstarts on every pull request; thepull_requestpath filter is gone.pushkeeps its filter, so merges that change no code still skip CI.packages/,tooling/,package.json,.github/actions|workflows/, the lockfile and root configs), it setsSKIP_CI=true. Every later step skips, so the job ends green in seconds.Verification
bash -eo pipefailon sample file lists, skips agent-only, docs-only andapps/www-only changes and runs for a package, the lockfile or a workflow file. A missing base fails the step..github/workflows/ci.yml, so its own CI runs the full suite; the green-skip path shows on the next agent-only PR, chore(pstack): land card worktree commits and hold commits no ref reaches #5182, after rebasing it.Not in this PR
Vercelis also required onmain, butvercel.jsondisables deployments for every branch exceptmain, so Vercel never reports a status on any PR (none on #5172, #5180 or #5181). RemovingVercelfrom the ruleset's required checks is a repository settings change for the owner.Shipped fast, no review.