Skip to content

ci: report a green CI check on PRs that change no code - #5184

Merged
zbeyens merged 1 commit into
mainfrom
codex/ci-green-agent-prs
Oct 17, 2026
Merged

zbeyens merged 1 commit into
mainfrom
codex/ci-green-agent-prs

Conversation

@zbeyens

@zbeyens zbeyens commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Why

main's ruleset requires the CI check. After #5183 dropped agent files from CI's path filter, an agent-only PR such as #5182 never started the workflow, so CI sat at "Expected — Waiting for status to be reported". Docs-only and apps/www-only PRs already had the same problem.

What changed

  • ci.yml starts on every pull request; the pull_request path filter is gone. push keeps its filter, so merges that change no code still skip CI.
  • A new first step, after checkout, diffs the PR against its base. When nothing matches the paths that used to trigger CI (packages/, tooling/, package.json, .github/actions|workflows/, the lockfile and root configs), it sets SKIP_CI=true. Every later step skips, so the job ends green in seconds.
  • When the base commit cannot be read, the diff fails and the job fails instead of skipping.

Verification

  • The workflow parses as YAML.
  • The step's matcher, run under bash -eo pipefail on sample file lists, skips agent-only, docs-only and apps/www-only changes and runs for a package, the lockfile or a workflow file. A missing base fails the step.
  • Not run: this PR changes .github/workflows/ci.yml, so its own CI runs the full suite; the green-skip path shows on the next agent-only PR, chore(pstack): land card worktree commits and hold commits no ref reaches #5182, after rebasing it.

Not in this PR

Vercel is also required on main, but vercel.json disables deployments for every branch except main, so Vercel never reports a status on any PR (none on #5172, #5180 or #5181). Removing Vercel from the ruleset's required checks is a repository settings change for the owner.

Shipped fast, no review.

The main ruleset requires the CI check, but a PR outside CI's path filter never
started the workflow, so the check waited forever. CI now starts on every pull
request. When the PR changes none of the paths that used to trigger it, a first
step marks the run skipped and every later step is bypassed, so the required
check passes in seconds. Pushes keep their path filter.

Shipped fast, no review.
@zbeyens
zbeyens requested a review from a team October 16, 2026 23:58
@codesandbox

codesandbox Bot commented Oct 16, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@changeset-bot

changeset-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 159e7f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-16T23:58:29.385839Z 159e7f5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@zbeyens
zbeyens merged commit 9208b4e into main Oct 17, 2026
4 checks passed
@zbeyens
zbeyens deleted the codex/ci-green-agent-prs branch October 17, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant