Skip to content

refactor row search and filter - #5

Merged
raylrui merged 1 commit into
mainfrom
feat/table-row-search
Sep 22, 2026
Merged

raylrui merged 1 commit into
mainfrom
feat/table-row-search

Conversation

@raylrui

@raylrui raylrui commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

changes

  • New search box on each table: matches rows whose value in a chosen text column contains the typed text (case-insensitive), debounced while typing, immediate on Enter. Column defaults to libraryId where present.
  • The old always-open filter panel is now an Advanced filter button (closed by default) showing the active condition count; search and filter combine with AND.
  • Search state (q, qcol) lives in the URL alongside the existing filter, so views stay shareable.
  • Depends on the mart API allowing the includesInsensitive filter operator (see companion orcahouse PR below) — the box hides itself if the API doesn't offer it yet.
  • README split into focused docs. Root README trimmed to intro, quick start, commands, and key facts.

@raylrui
raylrui requested a lite review from Copilot September 22, 2026 06:58
@raylrui raylrui self-assigned this Sep 22, 2026
@raylrui raylrui added the enhancement New feature or request label Sep 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The changes span search behavior, filtering, URL state, UI integration, and documentation, warranting final human review.

Review effort: Lite
Findings: None

What changed in this PR

Refactors table browsing with URL-shareable, debounced row search, collapsible advanced filters, and reorganized documentation.

Changes:

  • Adds case-insensitive search with column selection and API-aware behavior.
  • Combines search and advanced filters with AND semantics.
  • Splits project documentation into focused guides.
File Description
src/​lib/​schema.ts Registers the search operator.
src/​lib/​row-search.ts Provides search-field and clause helpers.
src/​lib/​filters.ts Combines filter inputs.
src/​components/​TableBrowser.tsx Integrates search and advanced filters.
src/​components/​RowSearch.tsx Implements the debounced search UI.
README.md Provides a concise project overview.
docs/​local-development.md Documents local setup.
docs/​how-it-works.md Documents runtime and search behavior.
docs/​development-guide.md Documents development conventions.
docs/​deployment.md Documents deployment and API dependencies.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@raylrui
raylrui merged commit 605b337 into main Sep 22, 2026
7 checks passed
@raylrui
raylrui deleted the feat/table-row-search branch September 30, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants