Update go to 1.26, bump dependencies and apply go fix - #58
Merged
Conversation
Contributor
Author
|
The coveralls check reports a 0.07% decrease, which is arithmetic rather than a coverage regression: The counts from the coverage profiles, master against this branch: |
umputun
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance pass, no functional changes.
Go and dependencies
The
godirective moves from 1.24.0 to 1.26.0 and the workflowgo-versionfollows;umputun/baseimage:buildgo-latestcurrently ships Go 1.26.0, so the Docker build is unaffected. Dependencies updated withgo get -u ./..., thengo mod tidyandgo mod vendor. The bulk of the vendor diff comes from go-dockerclient 1.12.3 -> 1.13.2, which replaces the vendoreddocker/dockertree withmoby/moby/client; testify 1.11.1 -> 1.12.1 accounts for the rest.CI
actions/checkoutandactions/setup-gobumped to v7, golangci-lint pinned to v2.12.2.go fix
go fix ./app/...applied as a separate commit:slices.Contains,sync.WaitGroup.Go,interface{}->any,for i := range 100, and the removal ofomitemptyfrom the twotime.Timefields ofcore.Request. That last one is a no-op on the wire, sinceencoding/jsonignoresomitemptyfor struct values and always emitted both fields; the README snippet of the same struct is updated to match.Tests pass with
-raceagainst both mongo 4.4 and mongo 8, and golangci-lint v2.12.2 reports no issues.