Fix session/new failing when kate-mcp-server is included#4
Open
molove wants to merge 11 commits intoundefinedopcode:mainfrom
Open
Fix session/new failing when kate-mcp-server is included#4molove wants to merge 11 commits intoundefinedopcode:mainfrom
molove wants to merge 11 commits intoundefinedopcode:mainfrom
Conversation
The MCP server entry in the session/new mcpServers array included a "type": "stdio" field. The claude-agent-acp handler branches on the presence of a "type" key: with it, the entry is treated as HTTP/SSE and only url/headers are read (command is ignored, url is undefined); without it, the entry is treated as stdio and command/args/env are read correctly. Removing the "type" field causes the ACP agent to take the stdio branch and successfully launch kate-mcp-server, fixing the Internal error -32603 "Query closed before response received" that prevented sessions from being created. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Builds from molove/kate-code which includes the fix for the kate-mcp-server stdio type field issue. Revert this line once the fix is merged upstream into undefinedopcode/kate-code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r fixes - Named session picker on connect with resume-by-ID support - Session notes via katecode_set_session_note MCP tool - Flag concern button on permission requests - Material Symbols variable font integration - Fix diff text invisible: propagate foreground colours to CSS variables - Fix terminal output invisible: derive terminal-fg from code background lightness rather than KDE UI theme (fixes mismatch between Kate editor theme and KDE system theme) - Add session picker, concern flag, and MCP tool handlers to D-Bus service Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Exposes the current kate-code session ID via a new MCP tool so that Claude can retrieve it programmatically rather than parsing the "Connected! Session ID:" system message. This makes it straightforward to call katecode_set_session_note at the end of any session without requiring the user to copy/paste the ID. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
claude-code-acp is a symlink created by the AUR package pointing to claude-agent-acp. On a fresh install without the AUR symlink, the plugin would fail to connect. Use the canonical binary name instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- System install requires --prefix /usr on Arch (cmake defaults to /usr/local) - Update all claude-code-acp binary references to claude-agent-acp Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
MCP tool parameters (old_string/new_string) travel via the MCP protocol
directly to kate-mcp-server, not through ACP's rawInput field, so live
tool_call events always had rawInput={} and no diff data to display.
Fix for mcp__kate__katecode_edit: EditorDBusService emits editApplied()
after a successful D-Bus edit. ChatWidget queues this data and injects
it into the diff display when tool_call_update arrives.
Fix for built-in Edit tool: ACPSession captures the old file content
before writing in handleFsWriteTextFile() and emits fsEditApplied(),
which feeds into the same ChatWidget queue.
A new setToolCallDiff() JS function updates the stored tool call's
oldText/newText and re-renders the message, so diffs appear correctly
for both code paths.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tools - katecode_read_clipboard: reads current clipboard text via QGuiApplication::clipboard() - katecode_paste_to_terminal: sends text to Kate's embedded terminal without executing (no Enter key) via TerminalInterface, searching the main window widget tree for the KonsolePart - Add KF6::Parts dependency for kde_terminal_interface.h Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP server entry in the session/new mcpServers array included a "type": "stdio" field. The claude-agent-acp handler branches on the presence of a "type" key: with it, the entry is treated as HTTP/SSE and only url/headers are read (command is ignored, url is undefined); without it, the entry is treated as stdio and command/args/env are read correctly.
Removing the "type" field causes the ACP agent to take the stdio branch and successfully launch kate-mcp-server, fixing the Internal error -32603 "Query closed before response received" that prevented sessions from being created.