Workaround for web-configurator hangs in setup flow#59
Open
RyanGerleve wants to merge 1 commit into
Open
Conversation
- The web-configurator could get stuck when continuing a first-time setup that was previously canceled or interrupted. Added delays as a workaround.
Contributor
|
Did you use the latest main branch of the integration (v0.7.0) and with which Remote firmware version did you test with? |
Author
Yes, latest main branch and firmware 2.9.4. I had also tested on firmware 2.9.3 before updating my remote, and it had the same behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the web-configurator can get stuck in the integration setup flow in certain cases. It happens when the first initial setup of an integration is canceled or errors/times out, then restarted by clicking on its tile in the web configurator. If the integration then requests a user input or user confirmation screen, the web UI will hang until it times out.
This is easily reproduced with the setup_flow example:
I saw the existing sleep calls and comments in the setup flow code that imply they're workarounds for the web-configurator, so I tried that here, and it worked. So maybe it's acceptable for a pull request!
Interestingly, I also tested this using the setup_flow example in the node integration library, but I couldn't reproduce it consistently.