fix: entity grounding, latency bands, STOI sliding-window, null guards, overlap fix, silence threshold#5
Merged
Conversation
- Fix unsorted imports (I001) in 5 files - Add missing trailing newlines (W292) in 4 files - Use ternary expressions instead of if-else (SIM108, SIM201) - Add missing CallTrace import in orchestrator.py (F821) - Add noqa for FastAPI File() default arg pattern (B008)
- BaseEvaluator.evaluate: scenario is required (Scenario), not Optional; fixes 8 Liskov-substitution violations in wer/mos/latency/interruption/ hallucination/compliance/stoi/silence evaluators - Orchestrator.evaluate_trace: skip evaluators when scenario is None - upload.py: add type annotations (Click ctx) and return type for upload_audio and inner _run; use save_call_evaluation(trace, result) instead of non-existent save_eval_result - api/routes/calls.py: replace DecibenchConfig = ... sentinel with Depends(get_config) so FastAPI performs proper dependency injection and mypy can type-check the parameter All 341 tests pass, ruff lint/format/mypy clean.
…ow, null guards, overlap fix, silence threshold
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source files (10 modified)
response_gapandturn_gapband tuples toLatencyScoringConfigresponse_gap_max_mstranscript.text(was crashing onNone)\b) for entity grounding, preventing false matches like "500" inside "1500"+ chunk)response_gap_avg_msthreshold reads fromlatency_bandswith fallbackintelligibility_estimatecurve fixed (was producing negative scores);response_gap/turn_gapusescore_banddead_air_max_msdefault changed from 3000 to 1500Test files (8 modified + 1 new)