Skip to content

Update package:intl4x for Dart and add likely_subtags support - #556

Open
mosuem wants to merge 12 commits into
mainfrom
updateDartv1
Open

Update package:intl4x for Dart and add likely_subtags support#556
mosuem wants to merge 12 commits into
mainfrom
updateDartv1

Conversation

@mosuem

@mosuem mosuem commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR updates the Dart test executor to support the latest package:intl4x and package:icu4x, adds likely_subtags support across both Native and Web platforms, and improves test configurations and CI stability.

Key Changes

  1. likely_subtags Implementation:

    • Implemented likely_subtags using package:intl4x/locale.dart unified across both Dart Native and Dart Web:
      • Locale.maximize().toLanguageTag() for maximize
      • Locale.minimize().toLanguageTag() for minimize and minimizeFavorRegion
      • minimizeFavorScript is marked as unsupported, aligning with ECMAScript 402 (Intl.Locale.prototype.minimize()), ICU4C, and ICU4J.
    • Removed platform-specific files (likely_subtags_native.dart and likely_subtags_web.dart).
  2. Dependencies & Versioning:

    • Updated icu4x dependency to ^2.3.1.
    • Pinned package:intl4x to git commit a3c72590b83f60c3631ece8064d7990840eed187 (dart-lang/i18n#1091), which introduces maximize(), minimize(), and canonicalize() on Locale.
    • Regenerated version tracking files via bin/set_version.dart and bin/make_runnable_by_node.dart.
  3. Plural Rules & Datetime Format:

    • Adapted plural_rules.dart for the updated PluralRules.select API.
    • Fixed timezone formatting and display names handling.
  4. Test Configurations (run_config.json):

    • Added likely_subtags to all Dart configurations (Native on icu77, Web on icu73icu78).
    • Added dart_web on icu78 (Node 26.3.0).
  5. CI Stability (verifier/verifier.py):

    • Capped multiprocessing in verifier.parallel_verify_data_results to min(2, mp.cpu_count()) (matching schema/schema_validator.py) to prevent runner OOM (Exit Code 137) when verifying large test plans (e.g. collation).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dart SDK environment constraint to ^3.12.0 and upgrades several dependencies in pubspec.yaml and pubspec.lock. It also attempts to change how dateStyle and timeStyle are added to the options map in datetime_format.dart. However, the introduced syntax 'dateStyle': ?dateStyle is invalid in Dart and will cause a compilation error. It is recommended to revert to the original collection-if syntax (if (dateStyle != null)) to conditionally include these keys.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread executors/dart/lib/datetime_format.dart
@mosuem
mosuem marked this pull request as ready for review June 30, 2026 13:44
@mosuem
mosuem requested a review from sffc June 30, 2026 13:44
@mosuem mosuem changed the title Update package:intl4x to 1.0.0-alpha.1 for Dart Update package:intl4x to 1.0.0-alpha.2 for Dart Sep 3, 2026
@mosuem mosuem changed the title Update package:intl4x to 1.0.0-alpha.2 for Dart Update package:intl4x for Dart and add likely_subtags support Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant