Update package:intl4x for Dart and add likely_subtags support - #556
Update package:intl4x for Dart and add likely_subtags support#556mosuem wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Dart SDK environment constraint to ^3.12.0 and upgrades several dependencies in pubspec.yaml and pubspec.lock. It also attempts to change how dateStyle and timeStyle are added to the options map in datetime_format.dart. However, the introduced syntax 'dateStyle': ?dateStyle is invalid in Dart and will cause a compilation error. It is recommended to revert to the original collection-if syntax (if (dateStyle != null)) to conditionally include these keys.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…ing, add icu78 web config
Summary
This PR updates the Dart test executor to support the latest
package:intl4xandpackage:icu4x, addslikely_subtagssupport across both Native and Web platforms, and improves test configurations and CI stability.Key Changes
likely_subtagsImplementation:likely_subtagsusingpackage:intl4x/locale.dartunified across both Dart Native and Dart Web:Locale.maximize().toLanguageTag()formaximizeLocale.minimize().toLanguageTag()forminimizeandminimizeFavorRegionminimizeFavorScriptis marked as unsupported, aligning with ECMAScript 402 (Intl.Locale.prototype.minimize()), ICU4C, and ICU4J.likely_subtags_native.dartandlikely_subtags_web.dart).Dependencies & Versioning:
icu4xdependency to^2.3.1.package:intl4xto git commita3c72590b83f60c3631ece8064d7990840eed187(dart-lang/i18n#1091), which introducesmaximize(),minimize(), andcanonicalize()onLocale.bin/set_version.dartandbin/make_runnable_by_node.dart.Plural Rules & Datetime Format:
plural_rules.dartfor the updatedPluralRules.selectAPI.Test Configurations (
run_config.json):likely_subtagsto all Dart configurations (Native onicu77, Web onicu73–icu78).dart_webonicu78(Node 26.3.0).CI Stability (
verifier/verifier.py):verifier.parallel_verify_data_resultstomin(2, mp.cpu_count())(matchingschema/schema_validator.py) to prevent runner OOM (Exit Code 137) when verifying large test plans (e.g. collation).