Fix for upcoming stringr 1.6.0 - #59
Merged
Merged
Conversation
`str_remove()` no longer accepts `NA` patterns since it's not clear what that means.
24 tasks
Contributor
Author
|
As a heads up, we're planning to submit stringr 1.6.0 to CRAN on November 3. |
Contributor
Author
|
@uribo FYI we are on track for a Nov 3 submission |
Owner
|
Hi @hadley, Thanks for the PR, and I owe you a real apology — I let this slip past me entirely, and as a direct consequence zipangu was archived from CRAN on 2025-12-13 (the failing test was exactly the one your patch fixed). That was on me, not on the heads-up you gave. Merging now, and I'll work on the remaining issues to prepare a resubmission to CRAN. Thanks again for catching it and for your patience. |
uribo
added a commit
that referenced
this pull request
Apr 28, 2026
- Declare R (>= 4.1.0) in DESCRIPTION (the package uses the native pipe |> and the lambda shorthand \(x); this was a NOTE in the CRAN checks that preceded the 2025-12-13 archival) - Bump RoxygenNote to 7.3.3 - Record the stringr 1.6.0 fix from #59 in NEWS - Exclude .claude/ from package builds and git history
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
str_remove()no longer acceptsNApatterns since it's not clear what that means.