Skip to content

Update compileSdk and targetSdk to 37#46

Merged
mateuszkwiecinski merged 11 commits into
masterfrom
udpates
Jul 22, 2026
Merged

Update compileSdk and targetSdk to 37#46
mateuszkwiecinski merged 11 commits into
masterfrom
udpates

Conversation

@mateuszkwiecinski

@mateuszkwiecinski mateuszkwiecinski commented Jul 22, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 22, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Diffuse output:

OLD: diffuse-base-file
NEW: keeper-gradle-plugin.jar

       │            compressed            │           uncompressed           
       ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 JAR   │ old       │ new       │ diff     │ old       │ new       │ diff     
───────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
 class │ 117.5 KiB │ 118.8 KiB │ +1.3 KiB │ 230.2 KiB │ 233.5 KiB │ +3.2 KiB 
 other │   5.4 KiB │   5.4 KiB │      0 B │  11.3 KiB │  11.3 KiB │      0 B 
───────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
 total │ 122.9 KiB │ 124.2 KiB │ +1.3 KiB │ 241.6 KiB │ 244.8 KiB │ +3.2 KiB 

 CLASSES │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  78 │  78 │  0 (+0 -0) 
 methods │ 585 │ 590 │ +5 (+5 -0) 
  fields │ 131 │ 131 │  0 (+0 -0)
JAR
     compressed      │    uncompressed     │                                                                               
──────────┬──────────┼──────────┬──────────┤                                                                               
 size     │ diff     │ size     │ diff     │ path                                                                          
──────────┼──────────┼──────────┼──────────┼───────────────────────────────────────────────────────────────────────────────
  7.4 KiB │ +1.3 KiB │ 21.1 KiB │ +3.2 KiB │ ∆ com/slack/keeper/KeeperPlugin.class                                         
  1.8 KiB │     +1 B │  3.5 KiB │      0 B │ ∆ com/slack/keeper/KeeperPlugin_Companion.class                               
  3.3 KiB │     +1 B │  8.4 KiB │      0 B │ ∆ com/slack/keeper/KeeperPlugin_configureKeepRulesGeneration_1.class          
    1 KiB │     +1 B │  1.5 KiB │      0 B │ ∆ com/slack/keeper/KeeperPlugin_configureR8Task_1.class                       
  1.8 KiB │     -1 B │    4 KiB │      0 B │ ∆ com/slack/keeper/KeeperPlugin_createIntermediateAppJar_taskProvider_2.class 
  1.9 KiB │     -1 B │  3.9 KiB │      0 B │ ∆ com/slack/keeper/KeeperPlugin_onApplicableVariants_1.class                  
  1.1 KiB │     -1 B │  2.1 KiB │      0 B │ ∆ com/slack/keeper/KeeperPluginKt_artifactView_1_1.class                      
  1.1 KiB │     -1 B │  2.1 KiB │      0 B │ ∆ com/slack/keeper/KeeperPluginKt_artifactView_1.class                        
  2.1 KiB │     +1 B │  4.4 KiB │      0 B │ ∆ com/slack/keeper/KeeperPluginKt.class                                       
──────────┼──────────┼──────────┼──────────┼───────────────────────────────────────────────────────────────────────────────
 21.6 KiB │ +1.3 KiB │ 51.1 KiB │ +3.2 KiB │ (total)
CLASSES
METHODS:

   old │ new │ diff       
  ─────┼─────┼────────────
   585 │ 590 │ +5 (+5 -0) 
  
  + java.io.File <init>(File, String)
  + kotlin.text.Regex <init>(String)
  + kotlin.text.Regex matches(CharSequence) → boolean
  + kotlin.text.StringsKt substringAfterLast_default(String, char, String, int, Object) → String
  + kotlin.text.StringsKt toIntOrNull(String) → Integer

Keeper resolves android.jar from the SDK's platforms dir by compileSdk
version, and GitHub runners don't preinstall android-37 yet.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 22, 2026 20:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 22, 2026 20:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Android 17 (API 37) ships platforms as minor-versioned SDK packages
(platforms;android-37.0) that install into e.g. platforms/android-37.0,
with no plain android-37 directory. Fall back to the highest installed
minor version when the exact directory is missing, and install
android-37.0 on CI.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 22, 2026 20:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

The validateL8 check requires java.time to be desugared, which D8 only
does when minSdk < 26 — with minSdk 29 the j$.time keep rules are never
generated and the check fails.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 22, 2026 20:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

The matrix's gradle dimension was only used in the job name — every job
ran the wrapper's Gradle, which this PR bumps to 9.6.1. Gradle 9.6
removed an internal API AGP 8.x depends on, so AGP 8 jobs must run the
pinned Gradle 9.5.0 via setup-gradle's provisioned distribution.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 22, 2026 20:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

AGP before 8.13 can't resolve minor-versioned SDK platforms
(platforms;android-37.0) and SDK 37 only ships in that scheme, so the
samples fall back to compileSdk 36 when built with legacy AGP.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 22, 2026 20:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

AGP 8.x can't run on Gradle 9.6+ and versions before 8.13 can't resolve
minor-versioned SDK platforms, so compileSdk 37 stays hardcoded and the
legacy matrix entries are removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 22, 2026 21:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mateuszkwiecinski
mateuszkwiecinski merged commit 43ed954 into master Jul 22, 2026
11 checks passed
@mateuszkwiecinski
mateuszkwiecinski deleted the udpates branch July 22, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants