Update compileSdk and targetSdk to 37#46
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Diffuse output: JARCLASSES |
Keeper resolves android.jar from the SDK's platforms dir by compileSdk version, and GitHub runners don't preinstall android-37 yet. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Android 17 (API 37) ships platforms as minor-versioned SDK packages (platforms;android-37.0) that install into e.g. platforms/android-37.0, with no plain android-37 directory. Fall back to the highest installed minor version when the exact directory is missing, and install android-37.0 on CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The validateL8 check requires java.time to be desugared, which D8 only does when minSdk < 26 — with minSdk 29 the j$.time keep rules are never generated and the check fails. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The matrix's gradle dimension was only used in the job name — every job ran the wrapper's Gradle, which this PR bumps to 9.6.1. Gradle 9.6 removed an internal API AGP 8.x depends on, so AGP 8 jobs must run the pinned Gradle 9.5.0 via setup-gradle's provisioned distribution. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AGP before 8.13 can't resolve minor-versioned SDK platforms (platforms;android-37.0) and SDK 37 only ships in that scheme, so the samples fall back to compileSdk 36 when built with legacy AGP. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AGP 8.x can't run on Gradle 9.6+ and versions before 8.13 can't resolve minor-versioned SDK platforms, so compileSdk 37 stays hardcoded and the legacy matrix entries are removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.