upgrade to AGP 8.2.2 and gradle 8.2 to support compileSdkVersion 34 - #1237
Open
seekstar wants to merge 1 commit into
Open
upgrade to AGP 8.2.2 and gradle 8.2 to support compileSdkVersion 34#1237seekstar wants to merge 1 commit into
seekstar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have used Vanilla Music for several years and I find that it doesn't work properly on my new phone running Android 15. Since I'm also a software developer (although I mainly develop database engines), I think maybe I can help to fix the compatibility problem. This is a practice PR to make me familiar with the Android App development.
The project already targets SDK 34, but AGP 7.3.1 predates API 34 and is not a supported combination for it (Gradle warns: "We recommend using a newer Android Gradle plugin to use compileSdk = 34"). This PR upgrades AGP to 8.2.2, the last patch of the 8.2 line: it is the first AGP line officially tested with API 34 and only requires Gradle 8.2 and JDK 17, keeping the toolchain bump minimal.
AGP 8 makes resource IDs non-final by default (android.nonFinalResIds=true) to speed up incremental compilation, so switch statements over R.* constants no longer compile. Convert them to if-else chains. No behavior change intended.
Other AGP 8 migrations: