Hopefully fix the R&D console crashing bug - #39456
Open
Inorien wants to merge 1 commit into
Open
Conversation
Contributor
|
Well done! |
Collaborator
|
https://www.byond.com/forum/post/2989192 Related post |
jwhitak
added
the
T-Thanks BYOND
Collaborator
Author
|
allegedly lummox has fixed this and will ship in byond 516.1684 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Works around a Byond bug whereby
browse()calls with a content param of jus under 65536 bytes and an opts param that pushes the total length just over 65536 bytes disconnects the client. This is a very narrow window that we occasionally hit with the R&D console. Seriously its something like 90 bytes wide and you just had to get unlucky to hit it, too small and there's no issue, too big and it seems to handle it properlyJust add some commented filler to the payload so it doesnt hit the danger zone, run on every browser open just in case
the bug in question has been reported to lummox
Why it's good
R&D console crashing bad
How it was tested
browse_crashguardproc and observed no crashingChangelog
🆑