Skip to content

More stuff scannable by modified device analyzers - #39512

Open
SECBATON-GRIFFON wants to merge 3 commits into
vgstation-coders:Bleeding-Edgefrom
SECBATON-GRIFFON:mod-dev-analyzer-stuff
Open

More stuff scannable by modified device analyzers#39512
SECBATON-GRIFFON wants to merge 3 commits into
vgstation-coders:Bleeding-Edgefrom
SECBATON-GRIFFON:mod-dev-analyzer-stuff

Conversation

@SECBATON-GRIFFON

@SECBATON-GRIFFON SECBATON-GRIFFON commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

[content][consistency]

What this does

Makes pinpointers, camera bugs, handheld TVs, mad scientist megaphones, KILLbots, syndicate tape, banana grenades, trophy belts, power gloves, picketpocket gloves of all kinds, laceup shoes, syndicate space suits, contortionist jumpsuits, space vietnam minos, flare gun flares, boozey shotgun shells and 357 speedloaders scannable by modified device analyzers.

Why it's good

There was no real need to forbid this stuff from being scanned when things like emags can be, plus it ignores things like implanters which would be too broken. (if anything else here feels that way please request to remove it)

How it was tested

Scanning the items on spawn with the modified device analyzer.

Changelog

🆑

  • rscadd: Pinpointers, camera bugs, handheld TVs, mad scientist megaphones, KILLbots, syndicate tape, banana grenades, trophy belts, power gloves, picketpocket gloves of all kinds, laceup shoes, syndicate space suits, contortionist jumpsuits, space vietnam minos, flare gun flares, boozey shotgun shells and 357 speedloaders are now scannable by modified device analyzers.
  • rscadd: The following research levels have been added to these items: Illegal 1 to PDApinpointers, mad scientist megaphones, KILLbots, syndicate tape, banana grenades, trophy belts, power gloves, picketpocket gloves of all kinds, laceup shoes, syndicate space suits, contortionist jumpsuits, space vietnam minos and boozey shotgun shells, Electromagnetic 1 to camera bugs and handheld TVs, and Combat 1 to flare gun flares and 357 speedloaders.

@D3athrow-Issues D3athrow-Issues added Consistency Issue This thing in question isn't consistent across multiple things. Content Adds something. Neat! labels Jul 18, 2026
@SECBATON-GRIFFON
SECBATON-GRIFFON marked this pull request as ready for review July 18, 2026 18:25
@PrimeDSS13

Copy link
Copy Markdown
Contributor

PR description + title leaves out key component of the PR, which is that all of these items become scannable via adding research levels to them. Considering a good few of these items are easily obtainable in a round, by giving them syndicate and illegal levels this type of research becomes much easier + more likely to appear in rounds.

@SECBATON-GRIFFON

SECBATON-GRIFFON commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

PR description + title leaves out key component of the PR, which is that all of these items become scannable via adding research levels to them. Considering a good few of these items are easily obtainable in a round, by giving them syndicate and illegal levels this type of research becomes much easier + more likely to appear in rounds.

will note this and adjust based on feedback, the ones i left have illegal research are generally only obtainable through the uplink.

@hacker-on-steroids

Copy link
Copy Markdown
Contributor

illegal research

once they get mats, the sciggers can print the tesla relay(illegal 3) so this is trivial to get anyway
i'd also bump the techlevels for stuff that doesn't spawn in maint way above illegal 1(only the toolbox has it this low iirc), freeform AI module has it at 8

@Inorien Inorien left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the slow review, been busy with irl these past weeks

Comment on lines +107 to +108
mech_flags = MECH_SCAN_ILLEGAL
origin_tech = Tc_SYNDICATE + "=1"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a bit weird for ntballoon, byondballoon and green balloon to have illegal tech on them, but it has the flag so shrug i guess

throw_speed = 4
throw_range = 20
flags = FPRINT | NO_ATTACK_MSG
origin_tech = Tc_MAGNETS + "=1"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this can be scanned by regular device analysers too, is that intended? differs from changelog

desc = "A handheld tv meant for remote viewing."
icon_state = "handtv"
w_class = W_CLASS_TINY
origin_tech = Tc_MAGNETS + "=1"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as camera bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Consistency Issue This thing in question isn't consistent across multiple things. Content Adds something. Neat!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants