Monkey temperature

[hacker-on-steroids]

What this does

makes monkeys wearing a spacesuit no longer get instafucked by stepping onto a space tile
closes #38738
closes #10888 - ten year anniversary!

Why it's good

How it was tested

spess_monke.mp4

note the temperature alert only shows up well after you're fucked, so i mangled something together afterwards

Changelog

🆑

• tweak: monkey spacesuits now protect against cold
• tweak: monkeys are slightly more cold resistant and no longer shiver at ambient temperature
• tweak: monkey low-temperature alert should now work better

[falcon2346]

Thank goodness that's finally getting fixed. Playing a nymph has been more annoying than usual because of the constant shivering in addition to the text spam

[hacker-on-steroids]

while i am aware that only taking into account the environment temperature and not the heat capacity is unrealistic(in reality you can live in 10C air but not 10C water), i'm leaving the creation of such a formula as an exercise to the reader

[Pancakemines]

I did some investigating and this issue seems to stem from #34518 where line 433 now 435 then used to check if the monkey was dead for this body temp equation im not really sure what the intent is here but it was changed to not dead this causesthe monkey to lose temp correctly in the first part of the code at line 411 and about 1.5 degrees due to being in space to losing a whopping 20 degrees at the second line. It should all be fixable without removing any code by just setting the stat check back to == instead of !=. As for the use of insulation this min to max change technically works against the purpose of it. The idea is that clothing that has a heat conductivity of 1 should act as if you're not wearing clothing at all when it comes to the process of transferring heat energy but as far as I can tell the only clothing you could ever wear on a monkey that would use this is a frying pan. A more correct fix is probably to just use that fact that its insulated in calculating thermal_protection instead of just max_protection maybe not as high as 0.5 but just a base addition of something like 0.2 at all times to account for having fur.

Edit: just tested swapping the stat check back to save you the effort and it does indeed fix space owning you. You still freeze pretty fast though on account of technically being naked but that would be handled either way with a baseline thermal protection or the min to max swap as you have now.

[hacker-on-steroids]

whopping 20 degrees

i removed that part because i feel that specifically dead monkeys being temperatured much faster adds nothing to gameplay while adding potential to be fucked up again in the future. a big inspiration was also the comment at

vgstation13/code/modules/mob/living/carbon/monkey/life.dm

Line 401 in 0f9a6dc

spaceproof = 1 //quick and dirt cheap. no need for the Life() of monkeys to become as complicated as the Life() of humans. man that's deep.

the idea is that clothing that has a heat conductivity of 1 should act as if you're not wearing clothing at all

please do the review thing that suggests changes, i'm not sure what exactly you want to do