Fix requirements for a working fresh install (networkx>=3.4, add yt-dlp)#2
Open
SungFeng-Huang wants to merge 1 commit into
Open
Fix requirements for a working fresh install (networkx>=3.4, add yt-dlp)#2SungFeng-Huang wants to merge 1 commit into
SungFeng-Huang wants to merge 1 commit into
Conversation
- networkx>=3.4: graph scripts call node_link_data/node_link_graph with the edges="links" kwarg, which only exists in NetworkX >= 3.4. Installing 3.0-3.3 makes `graph build/query/report` raise TypeError. - add yt-dlp: sync-metadata shells out to the `yt-dlp` CLI, so a fresh `pip install -r requirements.txt` otherwise fails with FileNotFoundError. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
SungFeng-Huang
force-pushed
the
fix/requirements-fresh-install
branch
from
July 8, 2026 13:55
a42547b to
428a997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two dependency declarations break a fresh
pip install -r requirements.txt:networkx>=3.0→networkx>=3.4:scripts/hungyi_graph.pycallsnode_link_data(..., edges="links")/node_link_graph(..., edges="links"). Theedges=keyword was only added in NetworkX 3.4, so installing 3.0–3.3 makesgraph build/query/reportraiseTypeError.yt-dlp:scripts/hungyi_kb.py(sync-metadata) shells out to theyt-dlpCLI viasubprocess. On a clean install without it, the command fails withFileNotFoundError.Why
Both
graph *andsync-metadataare documented maintenance commands, so a fresh install following the README currently can't run them.Test
requirements.txtchange only; no code changed.🤖 Generated with Claude Code