Skip to content

Drop the three retired remoted counters from both statistics schemas - #819

Open
ignaciogalle12git wants to merge 2 commits into
5.0.0from
enhancement/38280-reduce-remoted-agent-stats
Open

Drop the three retired remoted counters from both statistics schemas#819
ignaciogalle12git wants to merge 2 commits into
5.0.0from
enhancement/38280-reduce-remoted-agent-stats

Conversation

@ignaciogalle12git

@ignaciogalle12git ignaciogalle12git commented Aug 11, 2026

Copy link
Copy Markdown
Member

Description

Companion to wazuh/wazuh#38280 (wazuh/wazuh#38319), which retires three remoted counters with no reachable writer: states, ar (active response now excludes v[0-4] agents) and sent_breakdown.request (its channel has no clients left). They're listed under required in cluster_statistics_format_test_module/wazuh-manager-remoted_template.json, so test_statistics_format.py fails against a manager carrying that change.

Proposed Changes

  • Remove states, ar and sent_breakdown.request from cluster_statistics_format_test_module/wazuh-manager-remoted_template.json.
  • Delete agent_statistics_format_test_module/ entirely: GET /agents/{agent_id}/daemons/stats and its only consumer, test_agent_statistics_format, were removed from wazuh/wazuh on 2026-08-13, so nothing reads it any more. Also drops its two dangling entries from setup.py.

control_breakdown.request, control and sent_breakdown.shared stay: different struct, or still real 4.x traffic.

Results and Evidence

No remaining reference to agent_statistics_format_test_module anywhere in wazuh/wazuh. test_cluster_statistics_format still exercises GET /cluster/{node_id}/daemons/stats against the updated schema. Not run against a deployed 5.0 manager.

@ignaciogalle12git
ignaciogalle12git force-pushed the enhancement/38280-reduce-remoted-agent-stats branch from 16953ed to 97e65f1 Compare August 12, 2026 08:46
@ignaciogalle12git ignaciogalle12git changed the title Drop the removed remoted counters from the agent statistics schema Drop the retired states counter from both remoted statistics schemas Aug 12, 2026
@ignaciogalle12git ignaciogalle12git changed the title Drop the retired states counter from both remoted statistics schemas Drop the retired states and AR counters from both remoted statistics schemas Aug 12, 2026
@ignaciogalle12git ignaciogalle12git changed the title Drop the retired states and AR counters from both remoted statistics schemas Drop the three retired remoted counters from both statistics schemas Aug 13, 2026
@ignaciogalle12git
ignaciogalle12git force-pushed the enhancement/38280-reduce-remoted-agent-stats branch from 6331110 to 199515f Compare August 13, 2026 10:11
@ignaciogalle12git
ignaciogalle12git changed the base branch from main to 5.0.0-https August 13, 2026 10:11
@ignaciogalle12git
ignaciogalle12git marked this pull request as ready for review August 13, 2026 10:11
@ignaciogalle12git
ignaciogalle12git force-pushed the enhancement/38280-reduce-remoted-agent-stats branch from 199515f to 7aa7fa9 Compare August 14, 2026 14:38
Base automatically changed from 5.0.0-https to 5.0.0 August 14, 2026 19:32
@ignaciogalle12git
ignaciogalle12git force-pushed the enhancement/38280-reduce-remoted-agent-stats branch from 7aa7fa9 to 729c5fe Compare August 17, 2026 09:32
@ignaciogalle12git
ignaciogalle12git marked this pull request as draft August 17, 2026 09:48
@ignaciogalle12git
ignaciogalle12git marked this pull request as ready for review August 17, 2026 09:55
@ignaciogalle12git
ignaciogalle12git force-pushed the enhancement/38280-reduce-remoted-agent-stats branch from 12e719d to c626eb7 Compare August 17, 2026 12:05
…ics schema

- states, ar and sent_breakdown.request have no reachable writer since 5.x
  (wazuh/wazuh#38280); removed from properties and required in
  cluster_statistics_format_test_module/wazuh-manager-remoted_template.json
- test_statistics_format.py was failing against a manager carrying that change
GET /agents/{agent_id}/daemons/stats and its only consumer,
test_agent_statistics_format, were removed from wazuh/wazuh's integration
suite on 2026-08-13 along with the rest of the per-agent remoted statistics
surface. Nothing reads agent_statistics_format_test_module any more.

- Delete the module (wazuh-manager-remoted_template.json and the untouched
  wazuh-manager-analysisd_template.json)
- Drop the now-dangling entries from setup.py's package_data_list

cluster_statistics_format_test_module is unaffected: GET /cluster/{node_id}/daemons/stats
and test_cluster_statistics_format both still exist.
@ignaciogalle12git
ignaciogalle12git force-pushed the enhancement/38280-reduce-remoted-agent-stats branch from c626eb7 to 83ac61c Compare August 17, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce the remoted statistics set for 4.x agents and fix the framework collector

1 participant