feat: add optional dimensions to text2vec-aws vectorizer - #448
Merged
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
g-despot
force-pushed
the
feat/text2vec-aws-dimensions
branch
from
August 14, 2026 08:56
3b12f68 to
1e33462
Compare
The setting is only honoured for service `bedrock` with an `amazon.*` model; `sagemaker` and the `cohere.*` models accept it and embed at their own default size, so the old comment promised more than the server does. Split the "all values" test into one valid case per service. Core's `Validate` makes `endpoint` and `model` mutually exclusive — `endpoint` is rejected for `bedrock`, `model` for `sagemaker` — so a single case carrying both can never be a config the server accepts. The `bedrock` case now shows the combination `dimensions` applies to, `amazon.titan-embed-text-v2:0` at 512 dimensions, the pair core's own acceptance test uses; a new `sagemaker` case keeps `endpoint` covered in the service where it is legal. The "defaults" test is unchanged and still covers omit-when-unset.
g-despot
force-pushed
the
feat/text2vec-aws-dimensions
branch
from
August 14, 2026 09:39
1e33462 to
e388aba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
dimensionsparameter (output embedding dimensionality) to thetext2vec-awsvectorizer config. Omitted when unset, so the server applies its default.Closes #443