Skip to content

fix(recording): stabilize capture quality and CUDA export canvas #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meiiie merged 2 commits into from
May 27, 2026
Merged

fix(recording): stabilize capture quality and CUDA export canvas #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe82843
fix(recording): stabilize capture quality and CUDA export canvas
meiiie May 27, 2026
0235b4f
fix(export): address CUDA dimension review notes
meiiie May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion electron/ipc/export/native-video.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,9 @@ describe("getNativeExportCapabilities", () => {

expect(capabilities.nvidiaCuda.available).toBe(process.platform === "win32");
expect(capabilities.nvidiaCuda.hasWrapper).toBe(process.platform === "win32");
expect(capabilities.nvidiaCuda.hasNvidiaGpu).toBe(process.platform === "win32" ? true : null);
expect(capabilities.nvidiaCuda.hasNvidiaGpu).toBe(
process.platform === "win32" ? true : null,
);
});
});

Expand Down Expand Up @@ -600,6 +602,16 @@ describe("resolveExperimentalNvidiaCudaExportScriptPath", () => {
});

describe("buildExperimentalNvidiaCudaStaticLayoutArgs", () => {
it("passes output canvas dimensions to the CUDA wrapper", () => {
const args = buildExperimentalNvidiaCudaStaticLayoutArgs(
createNvidiaCudaSkipOptions({ width: 1020, height: 572 }),
"output.mp4",
"work",
);

expect(args).toEqual(expect.arrayContaining(["--width", "1020", "--height", "572"]));
});

it("keeps explicit copy-source CUDA audio inline by default", () => {
const args = buildExperimentalNvidiaCudaStaticLayoutArgs(
createNvidiaCudaSkipOptions({
Expand Down
8 changes: 5 additions & 3 deletions electron/ipc/export/native-video.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1990,9 +1990,7 @@ function isNvidiaCudaForceVideoOnlyEnabled() {
return process.env[NVIDIA_CUDA_FORCE_VIDEO_ONLY_ENV] === "1";
}

export function getNvidiaCudaAutoStallTimeoutMs(
autoCandidateActive = false,
) {
export function getNvidiaCudaAutoStallTimeoutMs(autoCandidateActive = false) {
if (!autoCandidateActive && !isExplicitNvidiaCudaExportEnabled()) {
return null;
}
Expand Down Expand Up @@ -2664,6 +2662,10 @@ export function buildExperimentalNvidiaCudaStaticLayoutArgs(
outputPath,
"--work-dir",
workDir,
"--width",
String(options.width),
"--height",
String(options.height),
"--fps",
String(Math.max(1, Math.round(options.frameRate))),
"--bitrate-mbps",
Expand Down
Loading