Fix async injected provider cleanup - #5210
Open
grandpig wants to merge 1 commit into
Open
Conversation
Signed-off-by: grandpig <grandpig@outlook.com>
🦋 Changeset detectedLatest commit: aa4fb33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
@tmm Hi! Would you mind taking a look at this when you have a chance? It fixes cleanup of the async injected-provider detection path and adds regression tests for both timeout-first and event-first cases. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ethereum#initializedlistener and clear the timeout once detection settlesPreviously, the listener registered for
ethereum#initializedwas an anonymous wrapper, while cleanup attempted to remove a different function reference. If the timeout settled first and the event was never emitted, the listener remained attached. If the event settled first, the uncancelled timeout could later perform another provider lookup.The new settlement path cleans up the listener and timeout before querying the provider and guards against concurrent settlement.
I have tested by the following cmd:
pnpm vitest run packages/core/src/connectors/injected.test.ts --project corepnpm --filter @wagmi/core check:typespnpm biome check packages/core/src/connectors/injected.ts packages/core/src/connectors/injected.test.ts .changeset/calm-ravens-listen.mdpnpm changeset status