Repository navigation
Conversation
Also check for an empty set rather than "no metadata", which SRI no longer returns.
Contributor
|
Also @yoavweiss probably has some fresh recollection of integrity metadata stuff. |
Contributor
AI ReviewThis looks right to me: SRI's parse metadata now returns an (ordered) set of maps, map equality is by value, and Infra's "unordered equal" is subset+superset, which also tolerates the duplicates SRI can currently produce (it uses list append rather than set append — probably worth an SRI issue). A few things:
|
noamr
approved these changes
Oct 13, 2026
Contributor
|
Needs implementation bugs, but you can mark chromium as interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A preloaded response can be reused when the consumer's strongest integrity metadata is unordered equal to that of the preload, as only the strongest metadata is used to check integrity. Also check for an empty set rather than "no metadata", which SRI no longer returns.
As a result, a consumer whose integrity metadata only contains unknown algorithms can reuse any preload, as SRI does not check integrity in that case.
From reading their code: Gecko already compares only the strongest metadata, ignoring order. Chromium compares the full parsed metadata, including order. WebKit instead checks the consumer's integrity metadata against the response when it is used.
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/links.html ( diff )