test: rename the claude_web fixture token to claude-web (WBC-991) - #73
Open
ClayMav wants to merge 1 commit into
Open
test: rename the claude_web fixture token to claude-web (WBC-991)#73ClayMav wants to merge 1 commit into
ClayMav wants to merge 1 commit into
Conversation
The documented vocabulary in studio-backend/docs/client-attribution.md is hyphenated (studio-frontend, python-sdk, sql-session), and the MCP server now emits claude-web. These fixtures still used the underscore form, which reads as if it were canonical. Fixture strings only. The driver appends its own hop and forwards the inbound chain untouched, so no behaviour changes.
![salty-hambot[bot]](https://avatars.githubusercontent.com/in/2952321?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed by Salty Hambot 🤖🧂 — rubric mode
Verdict: ✅ pass
| Dimension | Verdict | Notes |
|---|---|---|
| correctness | ✅ pass | Cosmetic test-fixture string rename; no logic touched. |
| security | ✅ pass | Auth-spoofing invariants remain fully exercised by unchanged tests. |
| privacy | ✅ pass | No data handling changes; only a fixture token string edited. |
| reliability | ✅ pass | No runtime paths affected by a test-string rename. |
| scalability | ✅ pass | Not applicable; test-only cosmetic change. |
| observability | ✅ pass | No logging or metrics impacted. |
| clarity/maintainability | ✅ pass | Rename aligns fixtures with the documented token vocabulary; improves consistency. |
| test quality | ✅ pass | Existing coverage intact; edit only normalizes a fixture value. |
A three-line s/claude_web/claude-web/ fixture rename with zero behavior change — both reviewers waved it through, and so do I. Ship it.
0 finding(s) posted.
💰 Review cost: $0.1693 · 47.0k in / 623 out tokens · ⏱️ 19.3s
💬 To request a re-review, comment @salty-hambot review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The documented token vocabulary in
studio-backend/docs/client-attribution.mdis hyphenated (studio-frontend,python-sdk,sql-session), and the MCP server now emitsclaude-web. These fixtures still usedclaude_web, which reads as if the underscore form were canonical.Fixture strings only, 4 occurrences in
tests/test_driver.py. The driver appends its own hop and forwards the inbound chain untouched, so the token value never affects behaviour. Nothing changes at runtime.Related Issues
Relates to WBC-991. Part of a sweep across the repos that carry this token in fixtures or docs, alongside
wherobots-python-sdk#29,wherobots-jdbc-driver, andstudio-backend#2515.Requester Checklist
Complete these before marking Ready for Review
Visual Proof
pre-commit run(ruff, ruff-format, codespell) passes on the changed file.Size Justification (if L/XL)
N/A — XS. One file, four string literals.
Reviewer Checklist
If these are not met, close the tab — this PR is not ready for review
Written by Claude Opus 5 in Claude Code.