Repository navigation
Conversation
Owner
Author
|
🎉 This PR is included in version 1.11.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the update checking logic in
updateAvailableItemand its related helpers to useasync/awaitinstead of fire-and-forget promises. The main goal is to ensure that cache updates and fetch operations complete before proceeding, which improves reliability and testability. The tests have also been updated to reflect the new asynchronous behavior.Refactoring to use async/await for update checks:
updateAvailableItemto be anasyncfunction and now awaits_internals.cacheRelease, ensuring that caching completes before continuing (src/helpers/updateAvailable.ts).cacheReleaseto be anasyncfunction and to await_internals.fetchAndStore, rather than calling it in a fire-and-forget manner, so that update checks are properly awaited (src/helpers/updateAvailable.ts).Test updates for async changes:
cacheReleaseandfetchAndStorewith async functions returning resolved promises, aligning with the new async behavior (src/helpers/updateAvailable.test.ts). [1] [2] [3] [4]src/helpers/updateAvailable.test.ts).