feat: add SetCipherList to override TLS 1.2 cipher list - #200
Open
freitasjca wants to merge 1 commit into
Open
Conversation
Add an abstract SetCipherList method to TCrossSslSocketBase and implement it in TCrossOpenSslSocket via SSL_CTX_set_cipher_list. Empty string is a no-op. An unrecognised cipher string (no matching ciphers) raises ESsl at call time rather than silently falling back to the context default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetCipherList(const ACipherList: string)as avirtual; abstractmethod onTCrossSslSocketBaseTCrossOpenSslSocketviaSSL_CTX_set_cipher_list, wrapped in the existingBeginTlsConfigUpdate/EndTlsConfigUpdatepairESslat call site rather than silently falling backMotivation
Some deployments need to restrict TLS 1.2 to a custom cipher list (e.g. to comply with FIPS or PCI-DSS profiles) without forking the library.
SetCipherListexposes the already-boundSSL_CTX_set_cipher_listthrough the public API.Notes
SSL_CTX_set_ciphersuites(not changed here)SSL_CTX_set_cipher_listbinding inNet.OpenSSL.pasis reused — no new import neededSetCertificate,SetPrivateKey, andAddCACertificate