Repository navigation
Bugfix: Run deferred callbacks in HTTP requests - #260
Merged
LukeTowers merged 2 commits intoOct 10, 2026
Merged
Conversation
Add Laravel's InvokeDeferredCallbacks middleware to the HTTP kernel so callbacks registered with defer() run after the response is sent.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LukeTowers
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defer()callbacks never run in web requests. Laravel runs them from theInvokeDeferredCallbacksmiddleware, which new Laravel apps get by default. Winter's HTTP kernel defines its own middleware list and doesn't include it, so the callbacks are silently dropped. This also breaksCache::flexible(),Concurrency::defer(), and thedeferredandbackgroundqueue connections.This PR adds the middleware to the kernel, in the same position Laravel uses, and adds a test that fails without the fix.
It also cherry-picks 6050387 from
develop(enshrined/svg-sanitize~1.0), sincewip/1.3doesn't install without it.