Translate fields nested in a fieldset form widget

[AIC-BV]

Fields nested inside a fieldset form widget never get their ml* widget, so translatable attributes grouped in a fieldset are not translatable in the backend.

registerModelTranslation() skips any nested form. That guard is right for repeater and nestedform: their fields belong to their own data scope and do not map to the model's translatable attributes. fieldset is different — it reuses the parent form's model and arrayName, and merges its getSaveData() straight back up, so its fields are model attributes exactly as if they had been declared on the parent form.

Core distinguishes the two cases with a new Form::$sharesModelScope flag (wintercms/winter#1528); this checks it, and the property_exists() guard keeps the plugin working unchanged on core releases that predate the property.

Depends on wintercms/winter#1528. Safe to merge independently: without core support property_exists() is false and behaviour is identical to today. If that PR settles on a different property name, this needs the same rename.

Tests

Added to tests/unit/classes/EventRegistryTest.php:

Test	Against Winter develop (what CI runs)	Against wintercms/winter#1529
fields in a nested form are not translated	passes	passes
fields in a model scoped nested form are translated	passes	passes
fieldset fields are translated (end-to-end, real FieldSet widget)	skipped	passes
fieldset fields inside a repeater are not translated	skipped	passes

The second test uses a Form subclass that declares sharesModelScope itself, so the new branch stays covered on core releases that predate the property — it does not silently become a no-op on today's CI. The last two go through the real fieldset widget and skip until core provides the flag. Reverting the guard fails tests 2 and 3; hardcoding the core flag to true instead of deriving it fails test 4, where a repeater sub-field sharing a name with a translatable attribute would otherwise be turned into an mltext.

Full plugin suite green against a patched core: 56 tests, 168 assertions.

Manual verification

Verified on a settings model with 22 translatable attributes, all inside type: fieldset groups: with the change all 22 render as ml* widgets inside the fieldset; with the original $widget->isNested guard restored, 0 — confirming the fieldset's inner form still reports isNested === true, so nothing else that relies on that flag is affected.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Corrected translation handling for fields in nested forms.
  • Fields in model-scoped nested forms and fieldsets are now translated correctly.
  • Prevented unintended translations for fields in regular nested forms and fieldsets inside repeaters.

• Tests

  • Added coverage for nested form, fieldset, repeater, and model-scoped translation scenarios.

[coderabbitai]

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: db082545-b20f-4292-b4af-d3f19a936094

📥 Commits

Reviewing files that changed from the base of the PR and between c66e8cf and 862131e.

📒 Files selected for processing (3)

• README.md
• classes/EventRegistry.php
• tests/unit/classes/EventRegistryTest.php

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ccc1af9c-79ea-424c-93d5-002e38467df6

📥 Commits

Reviewing files that changed from the base of the PR and between 62188e2 and c66e8cf.

📒 Files selected for processing (2)

• classes/EventRegistry.php
• tests/unit/classes/EventRegistryTest.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

registerModelTranslation now checks sharesModelScope when it processes nested forms. Nested forms without the shared model scope remain untranslated. Model-scoped nested forms and fieldset fields are translated. Fieldset fields inside repeaters remain untranslated. Unit tests and compatibility fixtures cover these cases.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to c66e8

This change enables translation widgets for fields inside fieldsets while preserving existing nested-form and repeater behavior; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: enabling translation for fields nested in a fieldset form widget.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[mjauvin]

@AIC-BV can you document sharesModelScope in the plugin ?

[AIC-BV]

@mjauvin done in f5d60d9: a new "Fields inside nested form widgets" section under Model translation in the README covers why nested widgets are skipped, why fieldset is the exception via Form::$sharesModelScope, and how a custom form widget that reuses the parent form's scope can opt in. It links wintercms/winter#1529 for now; happy to swap that for a version number once the core side lands.

[mjauvin]

@AIC-BV please fix Code Quality failing test

[AIC-BV]

@mjauvin not related to the code changes but okay 😀

[AIC-BV]

@mjauvin fixed in 862131e. The five findings were pre-existing style in the touched files (an empty catch {} on its own line and function( without a space on three closures), surfaced now that the Code Quality workflow from #122 runs on the PR. All checks are green.