Skip to content

feat: multiple media selection on Drive conversations - WPB-24046#4613

Open
jullianm wants to merge 10 commits intodevelopfrom
feat/drive-multiple-media-selection
Open

feat: multiple media selection on Drive conversations - WPB-24046#4613
jullianm wants to merge 10 commits intodevelopfrom
feat/drive-multiple-media-selection

Conversation

@jullianm
Copy link
Copy Markdown
Contributor

@jullianm jullianm commented Apr 22, 2026

TaskWPB-24046 [iOS] Improve sending multiple images on iOS

Issue

Currently user has to select each image from the gallery (custom and native one) one by one and approve it in full screen view.

This PR introduces changes to allow the user to frictionlessly upload multiple media at once.

Overview

  • On selection of an asset from the custom gallery (at the bottom), asset is now directly attached - no full screen confirmation.
  • Full screen confirmation now only opens on tap of the attached asset (image or video)
  • When the asset (image) is edited on that confirmation screen, it updates the attached asset.
  • The native PHPickerViewController is introduced to allow multiple media selection (previously UIImagePickerController was used)

Testing

Wire drive conversations

  • Hit camera icon button
  • Select multiple media image / video, observe that full screen confirmation screen no longer opens but selected media are directly attached and uploaded.
  • Hit “files” icon button, select multiple files and validate.
  • In the input bar, tap on image attachment, it now opens full screen confirmation, edit the image (draw something), tap “OK”, attachment image will be upated. Tapping “OK” or “Cancel” on an un-edited image will simply dimiss the screen
  • Tap again on that updated attachment to check that asset has been correctly updated.
  • Tap on a video attachment, observe that it opens the same full screen view, “OK” or “Cancel” simply dismisses the screen.
  • Tap on file attachment, observe that it doesn’t open anything..
  • In the media scrollable view, hit the “Gallery” icon button, it should open the native gallery screen allowing multiple media selection
  • Select multiple media (videos/images), validate and observe selected media are correctly attached.
  • Take a picture with the camera, observe that the draft is correctly attached
  • Remove some attachments and attach new media based on the previous use cases to ensure drafts behaviour is preserved.

Non-Wire drive conversations (non regression test)

  • Behaviour should be as before as nothing was changed for these conversations.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm requested review from a team, David-Henner, WilhelmOks and netbe and removed request for a team April 22, 2026 15:15
@jullianm jullianm requested a review from OlivellaO April 22, 2026 15:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Test Results

4 552 tests   4 525 ✅  7m 40s ⏱️
  601 suites     27 💤
    3 files        0 ❌

Results for commit 35d830e.

♻️ This comment has been updated with latest results.

Summary: workflow run #25305822495
Allure report (download zip): html-report-29641-feat_drive-multiple-media-selection

@jullianm jullianm requested review from johnxnguyen April 27, 2026 09:58
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant