Async ECC#347
Open
bigbrett wants to merge 2 commits intowolfSSL:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an asynchronous (Request/Response) API surface for ECC operations in the wolfHSM client, and extends the test suite to exercise the new async ECC flows (sign/verify, ECDH, and server-side keygen).
Changes:
- Expanded ECC client header documentation and introduced async Request/Response prototypes for ECC sign/verify, ECDH shared secret, and server-side keygen.
- Implemented ECC async Request/Response paths in the client crypto implementation and refactored blocking wrappers to reuse the Response helpers (including
WH_ERROR_BUFFER_SIZEbehavior). - Added comprehensive ECC async API tests and improved crypto-callback length propagation and error mapping for buffer-size errors.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
wolfhsm/wh_client_crypto.h |
Adds ECC async API declarations and extensive docblocks describing blocking + async ECC usage. |
src/wh_client_crypto.c |
Implements ECC async Request/Response functions and refactors ECC blocking wrappers to poll the shared Response helpers. |
src/wh_client_cryptocb.c |
Propagates output lengths on WH_ERROR_BUFFER_SIZE and maps it to wolfCrypt BUFFER_E for callback callers. |
test/wh_test_crypto.c |
Adds ECC async API test coverage and wires it into the crypto client test run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bigbrett
force-pushed
the
async-crypto-ecc
branch
from
b683b4f to
629cc1a
Compare
bigbrett
force-pushed
the
async-crypto-ecc
branch
from
629cc1a to
ecbcbe4
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #347
Scan targets checked: wolfhsm-crypto-bugs, wolfhsm-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described on the tin.