fips-baseline: re-add SSHKDF to default and FIPS providers#396
Open
ColtonWilley wants to merge 1 commit intomasterfrom
Open
fips-baseline: re-add SSHKDF to default and FIPS providers#396ColtonWilley wants to merge 1 commit intomasterfrom
ColtonWilley wants to merge 1 commit intomasterfrom
Conversation
SSHKDF (RFC 4253) was stripped from both the default and FIPS providers by
the fips-baseline patches, but the KDF is FIPS-compliant: it derives keys
using FIPS-approved hash functions (SHA-2 family). Stock OpenSSL 3 ships it
in both providers. wolfProvider implements it, and RHEL's openssh-kdf patch
(Patch964) routes every SSH key exchange through EVP_KDF_fetch("SSHKDF") —
so stripping it breaks RHEL-patched openssh entirely under the baseline.
Re-add the entry across all 4 defltprov and 5 fipsprov variant files so
callers using the fips-baseline build can fetch SSHKDF the same as they
would from stock OpenSSL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #382. The fips-baseline patches strip SSHKDF from the default and FIPS provider tables, but it's FIPS-compliant (SHA-2 only) and stock OpenSSL 3 ships it in both. Restoring it across the four defltprov and five fipsprov variants so applications built against fips-baseline OpenSSL can still
EVP_KDF_fetch("SSHKDF")-- specifically RHEL openssh, which goes through that fetch on every key exchange via Patch964.