Skip to content

Improve permission visibility for restricted team actions#1963

Draft
soamdesai-tfh wants to merge 2 commits into
mainfrom
permission-visibility-clean
Draft

Improve permission visibility for restricted team actions#1963
soamdesai-tfh wants to merge 2 commits into
mainfrom
permission-visibility-clean

Conversation

@soamdesai-tfh

Copy link
Copy Markdown
Contributor

Summary

  • Centralize team permission rules and use them for disabled permission UI.
  • Keep restricted controls visible with explanatory tooltips instead of hiding them.
  • Apply the permission UX across app configuration, World ID 4.0 flows, World ID actions, and team member management.
  • Replace broad scratch coverage with focused unit tests for permission policy, restricted UI behavior, member-row reasons, and RP action restrictions.

Validation

  • pnpm format:check
  • npx tsc --noEmit
  • npx jest web/tests/unit/permissions.test.ts web/tests/unit/member-row-actions.test.ts web/tests/unit/restricted-action.test.tsx web/tests/unit/tooltip.test.tsx web/tests/unit/use-team-permission.test.tsx web/tests/unit/world-id-40-restrictions.test.ts

One PERMISSION_RULES source of truth driving the permissions dialog and client gating; RestrictedAction/RestrictedButton/Tooltip/DisabledListItem/Tab-disabled primitives; disable-not-hide across app config, World ID 4.0/actions, API keys, team settings, and member management; migrate ad-hoc checkUserPermissions (incl. proxy.ts) onto userCanPerformAction. Snapshot for a minimization pass.

NOTE: includes an out-of-scope, NODE_ENV-gated local-dev World ID 4.0 SSM override in lib/feature-flags/world-id-4-0/server.ts that should be reverted before merge.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant