Fix: use Let's Encrypt certificates for all affected versions (product-is#28282) - #6312
Fix: use Let's Encrypt certificates for all affected versions (product-is#28282)#6312floze-the-genius wants to merge 2 commits into
Conversation
|
|
|
Warning Review limit reached
Next review available in: 47 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe guide replaces Comodo-specific instructions with a Let’s Encrypt Certbot workflow. It documents manual validation, generated certificate files, intermediate chains, and full-chain certificate-reply import into a Java keystore. ChangesCA-signed certificate workflow
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
en/includes/deploy/security/keystores/manage-ca-signed-certificates-in-a-keystore.md (1)
61-61: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMake the separate-chain fallback executable.
Add commands that import the root and intermediate certificates under distinct trusted aliases, then import
server-certificate.pemundercertalias. The current sentence does not show the required aliases or commands, so users can accidentally reuse the private-key alias for a CA certificate. (docs.oracle.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@en/includes/deploy/security/keystores/manage-ca-signed-certificates-in-a-keystore.md` at line 61, Expand the separate-chain fallback instructions to include executable keytool commands: import the root and intermediate CA certificates under distinct trusted aliases, then import server-certificate.pem using the certalias private-key alias. Ensure the commands preserve root-to-leaf order and prevent either CA certificate from reusing certalias.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@en/includes/deploy/security/keystores/manage-ca-signed-certificates-in-a-keystore.md`:
- Around line 53-58: Remove the hardcoded mypassword value and the -storepass
option from both keytool importcert examples, including the JKS and PKCS12
commands, so keytool prompts for the keystore password instead.
- Around line 25-34: Update the certificate procedure around Step 2 to document
CSR-based renewal using the same Certbot CSR flags and output paths, then import
the renewed full-chain certificate into the Java keystore. Keep all JKS import
commands consistent in keystore type and require interactive password prompting
rather than embedding passwords in commands.
- Around line 53-54: Update every keytool import and export command in the JKS
and PKCS12 blocks to explicitly specify the matching keystore format: add
-storetype JKS to commands in the JKS block and -storetype PKCS12 to commands in
the PKCS12 block, including the command around keytool -importcert.
---
Nitpick comments:
In
`@en/includes/deploy/security/keystores/manage-ca-signed-certificates-in-a-keystore.md`:
- Line 61: Expand the separate-chain fallback instructions to include executable
keytool commands: import the root and intermediate CA certificates under
distinct trusted aliases, then import server-certificate.pem using the certalias
private-key alias. Ensure the commands preserve root-to-leaf order and prevent
either CA certificate from reusing certalias.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro Plus
Run ID: e07817c4-d285-468c-8a51-dfe790c012ab
📒 Files selected for processing (1)
en/includes/deploy/security/keystores/manage-ca-signed-certificates-in-a-keystore.md
pavinduLakshan
left a comment
There was a problem hiding this comment.
I noticed that some parts of the documentation have been updated to exclusively use Let’s Encrypt certificates. Instead, Let’s Encrypt certificates should be presented merely as an example, rather than as the default or required approach.
Purpose
Resolves wso2/product-is#28282.
Replace the expired Comodo trial-certificate guidance in the shared CA-signed certificate include with a current Let's Encrypt/Certbot CSR flow. The update also removes hard-coded Comodo chain filenames and imports the full chain using the original private-key alias.
Affected documentation versions: 7.0.0, 7.1.0, 7.2.0, 7.3.0, and
next. All five pages consume the updated shared include.Related PRs
None.
Test environment
markdownlint-cli2: passed for the changed includemkdocs buildforen/identity-server/next: passed; the rendered page contains the new Certbot/full-chain guidance and no stale Comodo filenamesSecurity checks