Skip to content

Update getValueFromDecodedAssertion docs - #6313

Merged
AmshikaH merged 2 commits into
wso2:masterfrom
AmshikaH:master
Aug 11, 2026
Merged

Update getValueFromDecodedAssertion docs#6313
AmshikaH merged 2 commits into
wso2:masterfrom
AmshikaH:master

Conversation

@AmshikaH

@AmshikaH AmshikaH commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 47e62de6-602d-454e-be5a-afef2a9722be

📥 Commits

Reviewing files that changed from the base of the PR and between f99db7e and d9c82a3.

📒 Files selected for processing (3)
  • en/identity-server/7.3.0/docs/references/conditional-auth/api-reference.md
  • en/identity-server/next/docs/references/conditional-auth/api-reference.md
  • en/includes/references/conditional-auth/api-reference.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • en/includes/references/conditional-auth/api-reference.md
  • en/identity-server/7.3.0/docs/references/conditional-auth/api-reference.md
  • en/identity-server/next/docs/references/conditional-auth/api-reference.md

📝 Walkthrough

Walkthrough

Changes

JWT documentation clarification

Layer / File(s) Summary
Document JWT validation limitations
en/identity-server/.../api-reference.md, en/includes/references/conditional-auth/api-reference.md
The API references state that getValueFromDecodedAssertion() decodes JWTs without validating the signature, issuer, audience, or expiry.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the purpose and implementation reference, but it leaves the purpose placeholder and omits required sections and security checks. Replace $subject with the purpose, then add Related PRs, Test environment, and completed Security checks sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the documentation update for getValueFromDecodedAssertion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

var state = getValueFromDecodedAssertion(context.request.params.request[0],"state",true);
```

Note that this function only decodes the JWT — it does not verify the signature, issuer, audience, or expiry.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use note!!! box

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed with d9c82a3.

@AmshikaH
AmshikaH merged commit f7dc39a into wso2:master Aug 11, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants