Conversation
Owner
|
感谢 PR,不过反馈模块正在思考如何重建,会和此 PR 冲突,暂时先不完成此 Fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
工程主张与 Owner
feedback_service 在消息存在和归属检查后、数据库写入与外部评分前校验角色/审计类型;非法目标返回 422,保留 403/404/409。RefsComponent 隐藏非法目标的点赞/点踩入口,并在点击及弹窗提交时复核目标,保留复制、模型和来源。
决策记录:回答反馈目标契约。新增 422 行为仍请维护者确认,decision 保留 proposed。
验证情况
补充回归:
python -m pytest test/unit -m 'not slow' -q -o addopts=:2004 passed,另7 subtests。pnpm run test:unit:320 passed,0 failed。web/test/unit/pdfPreviewAssets.test.js两处 Buffer 未定义(24、40行);文件与基线 9820648 字节一致,不宣称全部门禁通过。Windows此前PDF路径测试失败,Linux全量未复现。简化 / 删除验收
不涉及。
独立语义 Review
独立 Reviewer 审查需求、完整反馈 diff 及测试,发现历史 DTO 缺失 role/status 时误隐藏按钮,已修复并补回归;复审确认闭合。最终交互测试和 decision 复审无新增阻断。Review 不替代测试。
未验证范围与风险
事故反馈
未认定为已发生的高影响线上事故;缺陷反证与回归已包含。
界面变更
浏览器隔离组件页验证:正常助手显示点赞/点踩/复制;审计及用户只保留复制,模型名保留。截图已本地检查,未上传公开附件;不是生产会话浏览器E2E。真实Vue模板与交互回归包含在PR中。
关联事项
无关联Issue。
补充说明
无数据库迁移、无新依赖,不自动部署。一个PR只处理反馈目标契约。