[501.2] Флакающие тесты в CI - #127
Merged
Merged
Conversation
marlowe-agent
added
bug
niqzart
approved these changes
Aug 11, 2026
marlowe-agent
added
the
ci:trigger
marlowe-agent
added
ci:trigger
marlowe-agent
force-pushed
the
fix/subject-name-collision
branch
2 times, most recently
from
August 11, 2026 23:28
75bc002 to
5418b2e
Compare
niqzart
approved these changes
Aug 11, 2026
marlowe-agent
force-pushed
the
fix/subject-name-collision
branch
from
August 11, 2026 23:41
5418b2e to
30d802f
Compare
random_part could be zero-length, so two subjects sharing a prefix/suffix within one batch could get an identical name. Postgres has no defined tie-break for ORDER BY on equal names, causing test_subject_autocompleting to flake on the resulting ambiguous order. Added a per-item unique letter to guarantee distinct names.
created_at is a client-side timestamp (datetime.now()) with no uniqueness guarantee, so two promocodes created in the same batch could tie. Postgres has no defined tie-break for ORDER BY on equal values, causing test_promocodes_listing to flake on the resulting ambiguous order. Added id as a secondary sort key to the query and the test's own expected-order sort.
marlowe-agent
force-pushed
the
fix/subject-name-collision
branch
from
August 11, 2026 23:45
30d802f to
e667e04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: xi-effect/xi.progress#194