fix(toast): use AlertCircle for error toasts + bump to 0.9.29 - #1223
Merged
Conversation
XCircle rendered an X-in-a-circle next to sonner's own close button, reading as a larger duplicate dismiss control. AlertCircle keeps the severity ramp at i / ! / warning and leaves the X unique to dismissal.
The cherry-picked toast fix carried a three-line comment explaining why the error icon is AlertCircle rather than XCircle, and that was enough to push src/App.tsx from 298 to 301 lines — past the 300-line limit, failing lint:file-size in fe-static. Shaving the comment to land exactly on 300 would keep a composition root at its cap and make the next one-line change someone else's problem. A severity->icon map is data, not composition, so it moves to src/components/toastIcons.tsx and takes the rationale with it. App.tsx drops to 292 lines with real headroom, and its lucide-react import goes too — the icons are now referenced in exactly one place. check:static passes end to end (file-size, knip, shell-slots, dependency-cruiser all green).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two commits, one CI cycle:
fix(toast)— error toasts useAlertCircleinstead ofXCircle. An X-in-a-circle reads as a second (larger) close button beside sonner's owncloseButton; keeping the severity ramp asi/!/⚠leaves the X unique to dismissal.chore— version bump to 0.9.29 across the five files plus the derivedsrc-tauri/Cargo.lock.Why they are in the same PR
Per
.claude/rules/40-version-bump.md, a standalone bump PR pays a full CI cycle to change five version strings. Folding the bump into the change being released halves the pipeline for a release. This is the first release to use that path.Notes
The toast change is presentational and carries no test: no test references the toast icon set, and
.claude/rules/10-tdd.mdexempts visual-only changes. The rationale is recorded as a comment at the call site so the next reader does not "fix" it back toXCircle.