feat(proto): add PullInDeadline, KpRotation, KpDeletion task variants + regen xmtp_proto

[insipx]

Proto-only base of the TaskRunner-recurrence stack. Adds three variants to the xmtp.mls.database.Task oneof (vendored regen):

• PullInDeadline (tag 4) — generic one-shot "run a task sooner" primitive: lowers a target task row's next_attempt_at_ns to MIN(current, not_later_than_ns), targeting the row by its unique data_hash.
• KpRotation (tag 5) / KpDeletion (tag 6) — recurring singleton tasks for key-package maintenance; empty payloads give each a stable data_hash so pull-ins can target them.

Minimal dispatch arms (warn + delete) keep xmtp_mls compiling standalone; real handlers land in the stacked PRs (#3806 generic layer, #3814 KP consumers).

gen/ is regenerated AHEAD of the upstream proto pin: xmtp/proto#339 carries all three messages; proto_version gets bumped to its merge SHA once it lands.

🤖 Generated with Claude Code

Note

Add PullInDeadline, KpRotation, and KpDeletion task variants to the MLS database worker

• Adds three new Task oneof variants to the protobuf schema in xmtp.mls.database.rs: PullInDeadline (with target_data_hash and not_later_than_ns), KpRotation, and KpDeletion.
• Regenerates serde impls and the proto descriptor binary to include these new types.
• Adds placeholder match arms in tasks.rs that log a warning and delete the task — no business logic is implemented yet.

^{Macroscope summarized bd706d7.}

[claude]

Claude finished @insipx's task —— View job

---

PR Review Complete

Review Date: 2026-07-06 16:20 UTC

---

Summary

This PR introduces proto-only scaffolding for TaskRunner recurrence features. The changes are minimal and well-scoped: three new task variants with stub handlers that log warnings and delete the tasks. This is appropriate preparatory work for the stacked PRs that will implement the actual handlers.

Findings

✅ No significant issues found

The implementation is sound for a proto-only PR:

1. Stub handlers are appropriate (tasks.rs:315-334) - The placeholder arms correctly:

   • Log warnings with sufficient context (task ID, data hash for PullInDeadline)
   • Delete tasks to prevent accumulation
   • Include comments explaining real handlers land in stacked PRs

2. Proto definitions are well-documented (xmtp.mls.database.rs:817-865):

   • PullInDeadline clearly documents its one-shot semantics and MIN operation
   • KpRotation and KpDeletion explain empty payloads yield stable data_hash
   • Type signatures are appropriate (bytes for hash, i64 for nanosecond timestamp)

3. Generated code follows conventions - Serde impls and descriptor binary are auto-generated via standard tooling

4. No security concerns - Stub handlers prevent any unintended behavior; real logic deferred to subsequent PRs

Minor Observations

• Test coverage: Codecov reports 0% patch coverage for the 6 new lines in tasks.rs. Consider adding integration tests in stacked PRs that verify:

  • PullInDeadline correctly updates next_attempt_at_ns with MIN logic
  • KP tasks respect singleton semantics (single row per type via stable data_hash)
  • Pull-ins targeting non-existent tasks are idempotent

• Error handling: The stub arms use ? propagation for delete_task (tasks.rs:324, 334). This is correct - DB errors should bubble up for retry logic.

Recommendation

Approved - This is clean foundational work. The placeholder handlers are safe and the proto definitions are clear. Proceed with the stacked PRs.

---

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.69%. Comparing base (b86545d) to head (bd706d7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/xmtp_mls/src/worker/tasks.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3805      +/-   ##
==========================================
- Coverage   84.70%   84.69%   -0.01%     
==========================================
  Files         409      409              
  Lines       60901    60907       +6     
==========================================
  Hits        51588    51588              
- Misses       9313     9319       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[macroscopeapp]

Approvability

Verdict: Approved

Proto schema additions with stub handlers that only log and delete tasks. The comments note nothing creates these task types yet - this is preparatory scaffolding. All changes are in files owned by the author, and the bulk is auto-generated protobuf code.

No code changes detected at bd706d7. Prior analysis still applies.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 3e7616c