fix(docs): hero demo overlapping long (Burmese) headings#91
Merged
Conversation
Long localized headings (e.g. Burmese) ran into the demo GIF column. Cap the hero text column to 500px, cancel VitePress's leftward image shift, and let the GIF fill its own column instead of a fixed 620px so the two never collide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo GIF column overlapped long localized headings. Cap the text column to 500px, remove VitePress's leftward image shift, and make the GIF fill its column (not a fixed 620px). Verified on en + my heroes.