Skip to content

Enhance make up and add make open#461

Merged
samdark merged 3 commits intomasterfrom
make-ux
Apr 21, 2026
Merged

Enhance make up and add make open#461
samdark merged 3 commits intomasterfrom
make-ux

Conversation

@samdark
Copy link
Copy Markdown
Member

@samdark samdark commented Apr 21, 2026

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues -

It adds make open that opens the app in the browser.

Also, it enhances the output of make up:

image

And in case of failure:

image

Copilot AI review requested due to automatic review settings April 21, 2026 15:59
@samdark samdark added the type:enhancement Enhancement label Apr 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6e00208a-6949-4123-aea5-f2ded281f7d3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch make-ux

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.32%. Comparing base (10a61e4) to head (fac21c0).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #461      +/-   ##
============================================
+ Coverage     85.08%   85.32%   +0.24%     
  Complexity       29       29              
============================================
  Files            11       11              
  Lines           181      184       +3     
============================================
+ Hits            154      157       +3     
  Misses           27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a convenience make open target to open the running Dockerized app in a browser, and improves make up output by printing the resolved localhost URL and providing better diagnostics when startup fails.

Changes:

  • Enhance make up to wait for containers and print the resolved http://localhost[:port] URL.
  • Add make open target to open the running app using a platform-appropriate opener.
  • Update README to document make open.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
README.md Documents the new make open command alongside existing Docker usage.
Makefile Adds open target and improves up with wait, URL output, and failure diagnostics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile
Comment thread Makefile
@samdark
Copy link
Copy Markdown
Member Author

samdark commented Apr 21, 2026

yiisoft/app-api#276

Comment thread Makefile
ifeq ($(PRIMARY_GOAL),up)
up: ## Up the dev environment.
$(DOCKER_COMPOSE_DEV) up -d --remove-orphans
@set -eu; \
Copy link
Copy Markdown
Member

@vjik vjik Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe extract these large scripts from Makefile to separate scripts?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are OK for now. Will extract these later probably.

@samdark samdark merged commit c218406 into master Apr 21, 2026
17 checks passed
@samdark samdark deleted the make-ux branch April 21, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants