Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
============================================
+ Coverage 85.08% 85.32% +0.24%
Complexity 29 29
============================================
Files 11 11
Lines 181 184 +3
============================================
+ Hits 154 157 +3
Misses 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a convenience make open target to open the running Dockerized app in a browser, and improves make up output by printing the resolved localhost URL and providing better diagnostics when startup fails.
Changes:
- Enhance
make upto wait for containers and print the resolvedhttp://localhost[:port]URL. - Add
make opentarget to open the running app using a platform-appropriate opener. - Update README to document
make open.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Documents the new make open command alongside existing Docker usage. |
| Makefile | Adds open target and improves up with wait, URL output, and failure diagnostics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ifeq ($(PRIMARY_GOAL),up) | ||
| up: ## Up the dev environment. | ||
| $(DOCKER_COMPOSE_DEV) up -d --remove-orphans | ||
| @set -eu; \ |
There was a problem hiding this comment.
Maybe extract these large scripts from Makefile to separate scripts?
There was a problem hiding this comment.
I think these are OK for now. Will extract these later probably.
Co-authored-by: Copilot <[email protected]>
It adds
make openthat opens the app in the browser.Also, it enhances the output of
make up:And in case of failure: