Repository navigation
Conversation
- Add YouVersionApi.verseImages with verseImages() and verseImage() for GET /v1/images and /v1/images/{image_id}
- Add VerseImage model
- Share the language_ranges[] URL helper between search and verse images
- Document the API in README and AGENTS.md; update the public API dump
Contributor
✅ Commit Lint: passedAll commit messages in this PR conform to Conventional Commits. 📦 Release preview:
|
camrun91
approved these changes
Oct 15, 2026
camrun91
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Approving with a few small follow-ups inline. The main one is holding the 2.7.0 release until Images is promoted out of beta.
- Reject blank passageId, pageToken, and imageId before any request - Share requireValidPageSize between search and verse images - Test that a page size of 99 is accepted - Update KDoc and README for the blank checks
Contributor
Code Coverage ReportOverall Line Coverage: 92.4%
Generated from Kover XML report. |
2 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YouVersionApi.verseImageswithverseImages()(GET /v1/images) andverseImage()(GET /v1/images/{image_id}). No UI.VerseImagemodel.language_ranges[]URL helper fromSearchEndpointsinto the sharedEndpointExtensions.ktso both APIs use it.pageSizeoutside 1–99 and an emptyimageIdbefore any request. Language ranges are not validated client-side, because this endpoint accepts*and_.README.mdandAGENTS.md, and update the public API dump.Test plan
VerseImagesEndpointsTests: URL building, including an image id with/kept as one path segmentVerseImagesApiTests: decoding of the list and single-image calls, an empty page, argument rejection with no request sent, and 401/403/500/malformed-body error mappingSearchEndpointsTestsstill pass after the helper move./gradlew testDebugUnitTest(1,779 tests, 0 failures)./gradlew :platform-core:apiCheckandspotlessCheck

Confidence Score: 5/5
The PR appears safe to merge; the previous documentation finding is fixed and no new issues were found.Summary
Adds verse-art list and detail calls through
YouVersionApi.verseImages, with theVerseImagemodel, tests, documentation, and public API entries.Reviews (4) · Last reviewed commit: "docs(core): document requireValidPageSiz..." · Reviewed by Greptile