qa: rewrite wallet_z_sendmany for the Z3 stack and re-enable it#147
Open
dannywillems wants to merge 3 commits into
Open
qa: rewrite wallet_z_sendmany for the Z3 stack and re-enable it#147dannywillems wants to merge 3 commits into
dannywillems wants to merge 3 commits into
Conversation
The historical zcashd z_sendmany test relied on RPCs zallet does not implement (z_exportviewingkey, sendtoaddress, the getwalletinfo shielded-balance fields, sapling z_getnewaddress) and on a pre-NU5 regtest chain, so it was disabled pending migration. Rewrite it against zebrad + zaino + zallet, preserving the coverage that remains meaningful on the Z3 regtest (NU5+ active from height 1): argument validation, a shielded Orchard happy path, multi-recipient sends, and the privacy-policy gating that is the core of z_sendmany (a transparent recipient is refused by default and allowed with AllowRevealedRecipients; a memo to a transparent recipient is rejected). The account is funded via z_shieldcoinbase, the source is an account UA, and the mandatory-null fee is exercised. Because zallet still maps some backend errors to a non-zcashd shape, the privacy-gating tests assert the success/failure outcome rather than pinning exact wording; the synchronous parse errors, which are stable, are asserted exactly. Move the test out of DISABLED_SCRIPTS and BASE_SCRIPTS into the Z3-stack NEW_SCRIPTS group. Co-Authored-By: Claude <noreply@anthropic.com>
Add a TODO documenting the privacy policies not yet covered by the Z3 rewrite (AllowRevealedSenders, AllowRevealedAmounts, AllowLinking- AccountAddresses, NoPrivacy), blocked until zallet can spend transparent/coinbase and Sapling sources in z_sendmany. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
We might deprecate |
pacu
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was initially part of !145 as sendmany and sendfromaccount share some logic.
The historical zcashd z_sendmany test relied on RPCs zallet does not implement (z_exportviewingkey, sendtoaddress, the getwalletinfo shielded-balance fields, sapling z_getnewaddress) and on a pre-NU5 regtest chain, so it was disabled pending migration.
Rewrite it against zebrad + zaino + zallet, preserving the coverage that remains meaningful on the Z3 regtest (NU5+ active from height 1): argument validation, a shielded Orchard happy path, multi-recipient sends, and the privacy-policy gating that is the core of z_sendmany (a transparent recipient is refused by default and allowed with AllowRevealedRecipients; a memo to a transparent recipient is rejected). The account is funded via z_shieldcoinbase, the source is an account UA, and the mandatory-null fee is exercised. Because zallet still maps some backend errors to a non-zcashd shape, the privacy-gating tests assert the success/failure outcome rather than pinning exact wording; the synchronous parse errors, which are stable, are asserted exactly.
Move the test out of DISABLED_SCRIPTS and BASE_SCRIPTS into the Z3-stack NEW_SCRIPTS group.