3/3 Run gRPC comparison test in CI#166
Open
pacu wants to merge 1 commit into
Open
Conversation
Build and package lightwalletd for integration tests, use the uv-managed environment in RPC jobs, and register grpc_comparison.py in the RPC test matrix. Keep the workflow changes separate from the manual test so reviewers can evaluate CI enablement independently. Co-Authored-By: OpenAI Codex <codex@openai.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack order:
Goal:
Enable the already-added gRPC comparison test in CI, keeping workflow changes separate from protocol plumbing and handwritten test logic.
What is included:
lightwalletdartifacts in CI.lightwalletdfor RPC and sec-hard jobs.lightwalletdexecutable alongside the other downloaded binaries.grpc_comparison.pyinqa/pull-tester/rpc-tests.py.ZALLET_BACKEND=${{ matrix.backend }}.Review focus:
This PR should be reviewed as CI enablement only. The test itself is in #165; generated protocol bindings are in #164.
Local checks run:
python -c "import yaml, pathlib; yaml.safe_load(pathlib.Path(\".github/workflows/ci.yml\").read_text())"bash -n .github/scripts/make-zcash-artifacts-executable.sh .github/scripts/stage-zallet-db-dump.shpython -m py_compile qa/pull-tester/rpc-tests.pytimeout 900s uv run ./qa/pull-tester/rpc-tests.py grpc_comparison.py --nocleanupCo-Authored-By: OpenAI Codex codex@openai.com