Conversation
We will use this to produce meshoptimizer-version.tar.gz which will be attached to release as an artifact. This is hash-stable as GitHub will not recompress it, and contains a subset of meshoptimizer repository - excluding files that are used for editor setup, Git repository management and extra demo content. js/ is included for web module consumers. Also temporarily let this run on 'arhive' branch to produce the artifact, and use v1.3 for checkout so that we get a correct .tar.gz built on GHA. This will be reverted in a later commit.
Instead of relying on objloader.cpp to build fast_obj.h implementation, we simply build it as part of main.cpp for now. If the build time increase becomes noticeable, this can be extracted into a separate file, but it works for now. This allows us to remove the references to any tools/ files from CMakeLists.txt as well as adjust the source archive to not include tools/ at all. Makefile which is used for internal development and should not be used externally continues to reference tools/ but is not packaged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will use this to produce
meshoptimizer-version.tar.gzwhich will beattached to releases as an artifact. This is hash-stable as GitHub will
not recompress it, and contains a subset of meshoptimizer repository -
excluding files that are used for editor setup, Git repository management
and extra demo content. js/ is included for web module consumers.
.tar.gzwas chosen over.zipbecause it embeds Git metadata, notably,the commit SHA, which can be retrieved via
git get-tar-commit-id:The first commit here builds the archive as-is from the v1.3 sources; this
requires inclusion of
tools/objloader.cppinto the archive. The resulting .tar.gzwas built by this GHA run and uploaded to v1.3 release retroactively, with SHA256
d50a0b5e1323ba4379cdb32f89436c20652b7393445f8e18c88ae64445b67b77
To simplify the structure for future releases, the second commit removes
tools/objloader.cpp(it was simply buildingfast_obj.h) so that the futurearchives do not need to package
tools/. This requires changingCMakeLists.txtso the 1.3 .tar.gz does not include this for consistency, but it will be part of 1.4.
Fixes #1098.