Resolve static-form queryable extension calls - #166
Merged
Merged
Conversation
Calling EntityFrameworkQueryableExtensions.AnyAsync(query) directly, rather than as an extension, generates code which does not compile. Generated with Claude Code
A static call such as EntityFrameworkQueryableExtensions.AnyAsync(query) had its type qualified without regard to the method, so it kept EF's type even when the sync method lives in System.Linq. The decision #164 made for extension calls is now a helper which both paths use. Generated with Claude Code
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 93.45% 93.47% +0.01%
==========================================
Files 10 10
Lines 1589 1593 +4
Branches 373 374 +1
==========================================
+ Hits 1485 1489 +4
Misses 26 26
Partials 78 78 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #165.
Static calls were qualified by type alone, without the method name, so
AnyAsyncstayed on EF's class. The*QueryableExtensionsdecision from #164 is now one helper used by both the static and extension paths.Generated with Claude Code