test: cover lease PDF normalize, open-ended overlap, payroll parse - #78
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add deterministic unit tests for native lease PDF/filename helpers, open-ended house-cover lease overlap, Boots-on-site other-work amount parsing, Norfolk visit month keys, and rent invoice month bounds. Co-authored-by: Jose I. Montero <2eezy77@users.noreply.github.com>
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
normalizeLeaseData,safeFilePart,formatDate)end_datenull/empty) counting toward house-cover active-tenant math$/comma strip, cent rounding) + Cash App pay labelscurrentMonthStart/currentMonthEnd(leap/short months,TZ=UTC)Test files added/updated
scripts/test-native-lease-pdf-normalize.jsscripts/test-native-lease-doc-helpers.js(+ pure extractsrc/services/native-lease-doc-helpers.js)scripts/test-leases-overlap-open-ended.jsscripts/test-site-visit-other-work-parse.jsscripts/test-site-visit-month-keys.jsscripts/test-rent-billing-month-bounds.jspackage.jsonscripts for the aboveWhy this reduces regression risk
These paths sit under lease PDFs, utility house-cover splits, associate payroll CTAs, visit month grouping, and rent invoicing — high blast radius if defaults, open-ended dates, money parse, or calendar bounds drift. Suites are deterministic (no DB/Stripe) and unique vs open coverage drafts #30–#77.
Validation
All passed locally.