Add UI for wheel selection [SYNTH-302] - #1477
Conversation
[SYNTH-301][SYNTH-302]
[SYNTH-302][SYNTH-302]
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Trust Commitment requirement. |
e47de6f to
66cf41b
Compare
f888449 to
2c322d9
Compare
b962ff3 to
463e5ee
Compare
Dhruv-0-Arora
left a comment
There was a problem hiding this comment.
So, circling back on this one after taking a step back and viewing it through a 30,000-foot lens, I want to say up front that while I appreciate the pushback, at the end of the day I think we're all singing from the same hymn sheet here, and honestly this is a home run — you've really moved the needle, taken the bull by the horns, and knocked it out of the park, so let's not reinvent the wheel or boil the ocean when the low-hanging fruit is already in the basket. I've run this up the flagpole, kicked the tires, and touched base with a few folks offline, and the consensus is that it passes the smell test with flying colors; there's no need to gold-plate it or let perfect be the enemy of good, because frankly the juice isn't worth the squeeze on further iterations. It is what it is, the proof will be in the pudding, and if it ain't broke we shouldn't be fixing it — so from where I sit, we're aligned, we're synergized, we're rowing in the same direction, and I have zero heartburn about giving this the green light. Let's not overthink it, let's not analysis-paralysis ourselves into a corner, let's put a pin in any remaining nitpicks, park them in the parking lot, and take them offline in a follow-up if they still have legs. Ship it, send it, stamp it, seal it — this dog will hunt, this ship has sailed in the best possible way, and I, for one, am giving it two enthusiastic thumbs up. Great stuff, really. No notes.
463e5ee to
86091eb
Compare
86091eb to
26410ee
Compare
3289edd to
6581614
Compare
| export function truncate(text: string, maxLen: number, addElipsis: boolean = false) { | ||
| if (text.length <= maxLen) return text | ||
| if (addElipsis) { | ||
| return text.slice(0, maxLen - 3) + "..." |
There was a problem hiding this comment.
erm we should use the unicode ellipse here
| return text.slice(0, maxLen - 3) + "..." | |
| return text.slice(0, maxLen - 3) + "…" |
Co-authored-by: Zach Rutman <92497727+rutmanz@users.noreply.github.com>
There was a problem hiding this comment.
The raycasting still seems to be off/inconsistent, and when I click apply when importing a copy of the onshape dozer I get this error and the import stalls
MirabufParser.ts:341 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading ‘value’)
at MirabufParser.findAncestralBreak (MirabufParser.ts:341:76)
at key (MirabufParser.ts:160:49)
at Array.forEach (<anonymous>)
at MirabufParser.initializeRigidGroups (MirabufParser.ts:156:27)
at new MirabufParser (MirabufParser.ts:90:14)
at computeWheelSubtreeParts (WheelJointBuilder.ts:26:30)
at WheelJointBuilder.ts:163:30
at Array.forEach (<anonymous>)
at applyWheelAssignments (WheelJointBuilder.ts:117:17)
at applyModelConfigChanges (ApplyModelConfig.ts:30:22)
|
|
||
| World.sceneRenderer.removeSceneObject(sceneId) | ||
|
|
||
| const rebuilt = await createMirabuf(assembly.info!.GUID!, assembly) |
There was a problem hiding this comment.
does it work for other games as well?

Task
SYNTH-302
Symptom
No real UI / workflow for selecting wheels or deleting parts in URDF imports
Solution
Added a UI
Verification
See checkboxes above. Import a URDF robot (ask on Slack if you need one) and go through the flow
Before merging, ensure the following criteria are met: