Repository navigation
let a study work through a list, passage by passage - #203
Merged
Merged
Conversation
groups.reading_list names a list the study works through: the parables, the encounters, the sayings, or a theme. groups.current_passage is the passage a manager last marked as where the study is; without one the study is at the first passage. Choosing a list makes the study a Highlighted in Red study. Both columns are nullable, so existing studies are untouched.
The new-study form offers 'Work through a list'. A study with a list shows it on its page with a 'We are here' marker and opens at that passage. /studies/:id/passages/:slug reads one passage in the study's reader: only that passage's verses, under the lens (an encounter stays undimmed), with a tab per gospel that tells it and previous/next through the study's own list. A manager can mark the passage as where the study is. Passages off the list, and people outside the study, get a 404. Because a telling sits inside one chapter, the page uses that chapter's existing live-update stream and shared highlights work as they do in a chapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A study can now work through the parables, the encounters, the sayings, or a theme, one passage at a time, with a marker for where the group is.
Starting one
The new-study form (and the edit form) gains Work through a list: no list, one of the three lists, or one of the eight themes. Choosing a list makes it a Highlighted in Red study.
The study page
A study with a list shows Working through: The Parables (or the theme's name), a button that opens the passage the study is on, and the whole list in order with a We are here badge. A study without a list looks exactly as before.
Reading a passage
/studies/:id/passages/:slugreads one passage in the study's own reader: only that passage's verses, under the red lens (an encounter stays undimmed), with a tab for each gospel that tells it. Previous / next step through the study's list, not through chapters. Passages that are not on the study's list, and people who are not in the study, get a 404.Where the study is
A manager sees Mark this as where we are on any passage; plain members don't. It is set by hand on purpose. The chapter-based Reading together card follows the latest shared highlight, but a group that meets weekly shouldn't be moved along because one member read ahead.
Schema
One migration adds two nullable columns to
groups:reading_listandcurrent_passage.db:prepareruns it on deploy; no manual step.Live updates
A telling always sits inside one chapter, so the passage page subscribes to that chapter's existing stream. Shared highlights and notes behave as they do on a chapter page; notes anchored elsewhere in the chapter are left out.
Specs
Model specs for the list, its validation, ordering and the current passage. Request specs for the form, the study page, the passage reader, stepping, other gospels, the three 404 cases, and who may move the marker. A system spec that starts a parables study from the form, reads two passages, marks one and sees the marker on the study page, plus axe (WCAG 2.1 AA) and 375px overflow on the form, the study page and a passage.
For the owner