fix(query): decode %5B/%5D dict keys like literal brackets (#1109) - #1223
Open
soniafergusonship wants to merge 1 commit into
Open
fix(query): decode %5B/%5D dict keys like literal brackets (#1109)#1223soniafergusonship wants to merge 1 commit into
soniafergusonship wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treats URL-encoded dictionary keys as equivalent to literal brackets in query parsing (#1109).
get_dict("page")already understoodpage[size]=3, butpage%5Bsize%5D=3was left as a flat key becauseqs_dict_name2kvonly looked for[/].Change
In
qs_dict_name2kv, when no literal[is present after the dict name, also accept%5B/%5D(case-insensitive hex) and return the inner key/value pair.Closes #1109