Skip to content

fix(query): decode %5B/%5D dict keys like literal brackets (#1109) #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soniafergusonship wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(query): decode %5B/%5D dict keys like literal brackets (#1109) #1223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions include/crow/query_string.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,31 @@ inline std::unique_ptr<std::pair<std::string, std::string>> qs_dict_name2kv(cons
skip_to_brace_open++;
skip_to_brace_close = strcspn(qs_kv[i], "]");

// Encoded brackets: page%5Bsize%5D=3 should match page[size]=3 (#1109).
if ( skip_to_brace_open == strlen(qs_kv[i]) )
{
const char* open = strstr(qs_kv[i] + name_len, "%5B");
if (!open)
open = strstr(qs_kv[i] + name_len, "%5b");
if ( open && open == qs_kv[i] + name_len )
{
const char* close = strstr(open + 3, "%5D");
if (!close)
close = strstr(open + 3, "%5d");
if ( close && nth == 0 )
{
auto key = std::string(open + 3, static_cast<size_t>(close - (open + 3)));
auto value = std::string(qs_kv[i] + skip_to_eq);
return std::unique_ptr<std::pair<std::string, std::string>>(new std::pair<std::string, std::string>(key, value));
}
else if ( close )
{
--nth;
continue;
}
}
}

if ( skip_to_brace_open <= skip_to_brace_close &&
skip_to_brace_open > 0 &&
skip_to_brace_close > 0 &&
Expand Down
Loading