Skip to content

Improvements to synthesis via filelist and simple filenames - #853

Merged
joanise merged 7 commits into
mainfrom
dev.ap/synthesis-improvements
Aug 25, 2026
Merged

Improvements to synthesis via filelist and simple filenames#853
joanise merged 7 commits into
mainfrom
dev.ap/synthesis-improvements

Conversation

@roedoejet

@roedoejet roedoejet commented Aug 19, 2026

Copy link
Copy Markdown
Member

PR Goal?

This PR does a couple small improvements to the synthesis operation in FS2 and STTS2. First, it implements the suggestion in #716 to allow simple basename synthesis when given a filelist. If you pass --simple-filenames then you just get the basename.wav

it also implements synthesizing with a filelist for STTS2 and fixes a small bug in the demo. All tested on trained models.

Assisted by Claude Sonnet 5

Fixes?

#716

Feedback sought?

rubber stamping, confirmation that the simple-filenames feature works as intended.

Priority?

medium

Tests added?

Some basic tests added

How to test?

Should work with existing models

Confidence?

pretty high

Version change?

Related PRs?

EveryVoiceTTS/FastSpeech2_lightning#154
EveryVoiceTTS/StyleTTS2#24

@semanticdiff-com

semanticdiff-com Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/base_cli/prediction_writing_callback.py  52% smaller
  everyvoice/demo/app.py  47% smaller
  everyvoice/model/e2e/StyleTTS2_lightning  0% smaller
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller

update to pytest
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.22%. Comparing base (cb28ffc) to head (bb15dd4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
everyvoice/demo/app.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   85.21%   85.22%   +0.01%     
==========================================
  Files          51       51              
  Lines        4706     4710       +4     
  Branches      699      700       +1     
==========================================
+ Hits         4010     4014       +4     
  Misses        535      535              
  Partials      161      161              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joanise

joanise commented Aug 20, 2026

Copy link
Copy Markdown
Member

Generally looks good. Effective solution. There's a test that fails in CI in fs2, and comments in both sub PRs.
I have reviewed the code changes carefully and the -h output, but I have not tested running synthesize. I assume Marc will be in a better position to do so.

minor fixes suggested by @joanise for synthesis improvements

@joanise joanise left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Conflicting submodule changes pushed, now you'll have to merge and/or rebase the submodules and redo a clean submodule update in this top-level PR.

@joanise
joanise merged commit 5785e63 into main Aug 25, 2026
8 of 9 checks passed
@joanise
joanise deleted the dev.ap/synthesis-improvements branch August 25, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants