feat: allow simple filenames for synthesis - #24
Conversation
|
|
||
| Or, for batch synthesis from a filelist: | ||
|
|
||
| **everyvoice synthesize text-to-wav logs_and_checkpoints/.../stage-2-last.ckpt \\ |
There was a problem hiding this comment.
This \\ at the end yields something that is not cut-and-pastable as is. But if you use \\ \\ instead, the output has a single \ and then multi-line cut and paste works.
There was a problem hiding this comment.
Another option that works even better is
```
everyvoice synthesize text-to-wav logs_and_checkpoints/.../stage-2-last.ckpt \\
--reference path/to/reference.wav \\
--text "Hello world" --text "How are you?"
```
this gives you something displayed as a code block, preserving indentation (the current solution does not), which is even better.
There was a problem hiding this comment.
I suppose, though, cut and pasting in this case is a silly concept, maybe never mind. But I might still consider using the code block option for our examples.
There was a problem hiding this comment.
yea, I don't think copy/paste is that important here. the code block option formats things a bit weirdly in my terminal, I think I'll leave this as is if that's alright
| # Fix a bug in the ffmpeg installation via awalsh128/cache-apt-pkgs-action | ||
| LD_LIBRARY_PATH: /usr/lib/x86_64-linux-gnu/lapack:/usr/lib/x86_64-linux-gnu/blas | ||
| steps: | ||
| - uses: actions/checkout@v6 |
There was a problem hiding this comment.
The current best practice recommendations are to add
with:
persist-credentials: false
every time we use actions/checkout, except for the rare cases where true is required (e.g., a workflow to needs to push to gh-pages), but I see that I have not started making that change anywhere in EV, nor even in Studio. It seems I only did it in g2p so far, so this comment is out-of-scope for this PR, but I wanted to mention it as something that I'll eventually spread everywhere, and is best practice to use when you create a new workflow.
| " You can only synthesize using one of these options", | ||
| file=sys.stderr, | ||
| ) | ||
| sys.exit(1) |
There was a problem hiding this comment.
Oh, another change that's going to be out of scope for this PR: this should be
raise typer.BadParameter(
"Got arguments for both --text and --filelist."
" You can only synthesize using one of these options"
)
instead of print and exit.
But I see that we have 39 instances of raise typer.BadParameter(...) and 43 instances of sys.exit(1) in the repo, so I'll make this a separate issue to do systematically: EveryVoiceTTS/EveryVoice#855
also allow synthesis of a filelist to match fs2 functionality
co-authored-by: @joanise
ab60d37 to
c5aa11b
Compare
EveryVoiceTTS/EveryVoice#853