Repository navigation
Change ref parameters to ref readonly for read-only cases - #99
Merged
Merged
Conversation
Co-authored-by: HMBSbige <19153265+HMBSbige@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update refs to be readonly
Change ref parameters to ref readonly for read-only cases
Oct 28, 2025
Owner
|
@copilot 肯定还有很多,检查所有文件,尤其是局部变量 |
Contributor
Author
I've analyzed all files for additional Method parameters: The existing changes (Poly1305X86.cs MultiplyR and ChaCha20Utils.cs Step) are the main opportunities for method parameters that can be made Local variables limitation: Most local For example, this pattern cannot use ref byte streamRef = ref stream.GetReference(); // Can't be ref readonly
ref Vector512<byte> v0 = ref Unsafe.As<byte, Vector512<byte>>(ref Unsafe.Add(ref streamRef, i)); // Needs mutable streamRefCould you clarify which specific local variables you'd like changed? I can look for other method parameters that might have been missed. |
HMBSbige
marked this pull request as ready for review
October 28, 2025 18:07
HMBSbige
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several methods pass parameters by
refwhen they're only read, not modified. This obscures intent and prevents potential compiler optimizations.Changes
MultiplyR(ref Vector128<uint> h01, h23, h44, ...)→ref readonlyfor the three input vectors used only in multiplication operationsStep(ref uint a, ref uint b, ref uint c, ...)→ref readonly uint bas it's only used ina += bExample
Note:
BroadcastVector128ToVector256cannot useref readonlyasUnsafe.AsPointerrequires mutable references even for read-only operations.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.