Skip to content

Change ref parameters to ref readonly for read-only cases #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HMBSbige merged 2 commits into from
Oct 28, 2025
Merged

Change ref parameters to ref readonly for read-only cases #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cffbca1
Initial plan
Copilot Oct 28, 2025
fc4e127
Change ref parameters to ref readonly where appropriate
Copilot Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CryptoBase/Macs/Poly1305/Poly1305X86.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ private void MultiplyR(ref uint a0, ref uint a1, ref uint a2, ref uint a3, ref u
/// d = h * r
/// </summary>
private void MultiplyR(
ref Vector128<uint> h01, ref Vector128<uint> h23, ref Vector128<uint> h44,
ref readonly Vector128<uint> h01, ref readonly Vector128<uint> h23, ref readonly Vector128<uint> h44,
out ulong d0, out ulong d1, out ulong d2, out ulong d3, out ulong d4)
{
// h0 * r0 + h2 * s3
Expand Down
2 changes: 1 addition & 1 deletion src/CryptoBase/SymmetricCryptos/StreamCryptos/ChaCha20Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ private static void QuarterRound(ref uint a, ref uint b, ref uint c, ref uint d)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static void Step(ref uint a, ref uint b, ref uint c, byte i)
private static void Step(ref uint a, ref readonly uint b, ref uint c, byte i)
{
a += b;
c = (a ^ c).RotateLeft(i);
Expand Down